Skip to content

[Maintainability] config set subcommand is missing from all generated shell completions #279

Description

@404-Page-Found

Description

The config subcommand in the completion metadata (SUBCOMMANDS in src/commands/completion.ts) only lists --help. The config set <key> <value> subcommand added in the CLI is not modeled, so bash/zsh/fish/powershell completions never suggest set after commit-echo config, nor the valid config keys (provider, model, baseUrl, apiKey, historySize, maxDiffSize, systemPromptTemplate, userPromptTemplate).

Location

src/commands/completion.ts lines 50–54 (config entry) and the SUBCOMMANDS metadata contract at lines 19–105

Code

{
  name: 'config',
  description: 'View current configuration',
  options: [{ flag: '--help', description: 'Display help for config' }],
},

Suggested fix

Model config set in the metadata (e.g. a value-consuming positional or a nested completion that lists the CONFIG_SET_KEYS from src/commands/config.ts), or at minimum add set as a subcommand token. Update the completion-command test that asserts scripts match --help output.

Impact

Inconsistent UX: config set is documented and usable, but completions stop at config, offering only --help.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions