Skip to content

[Bug Report]: Error Handling for fishery escapement #68

Description

@jcaracappa1

Atlantis version and Model name

Northeast US model. v6681+

Describe the bug

Escape Coefficient (Ka_escape_id) and Escape Exponent (Kb_escape_id) have a hard check as proportions in atlantisUtil/atUtilFisheryXML.c (L164 and L165). This was intented to make sure that the final excape proportion was positive (0 to 1). However, If doesn't allow escapement relationships with negative slopes (processes that exclude smaller fish more often). To allow this the no_checking option needs to be used.

Get_Fisheries_Escapement() in atHarvestCatch.c already checks if a negative FCescape is calculated and sets to zero to prevent errors in the catch equation.

Error Message

"Error flag Ka_escape_id must be between 0 and 1 (currently X)"

Valgrind output

NA

Is this a duplicate issue?

  • I have searched the existing data.

Provide the code and files used to run your model?

On any version change Ka_escape_XXX or Kb_escape_XXX to a negative number

Your set up (OS, RAM etc.)

Linux

Additional content

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Status
    Pending issues in repos

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions