Skip to content

GitHub comments_url Swagger metadata incorrectly describes Diff URL #248

Description

@daviburg

Problem

The pinned managed GitHub connector Swagger gives PullRequest.comments_url the same metadata as diff_url:

"comments_url": {
  "type": "string",
  "format": "uri",
  "x-ms-summary": "Pull Request Diff Url",
  "description": "The Diff URL for the pull request."
}

The C# collision fix correctly preserves both wire fields, mapping diff_url to DiffUrl and comments_url to PullRequestDiffUrl, but the generated XML summary for PullRequestDiffUrl remains misleading because documentation is emitted from this owner metadata.

Expected

Correct the managed connector Swagger metadata for PullRequest.comments_url to describe the comments URL, then regenerate the GitHub client. Do not hand-edit the generated SDK file.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggeneratorCodefulSdkGenerator issuesupstreamRequires a change or confirmation in another service or repository

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions