chore(main): release 0.3.7 - #3
Conversation
eba1f43 to
bc0ef1f
Compare
|
Retaining this PR because it is the clean, bot-managed release-please artifact for Disposition tracked in https://paperclip.blockcast.net/BLO/issues/BLO-20376. |
There was a problem hiding this comment.
Review — chore(main): release 0.3.7 @ bc0ef1fc7b
The diff itself is mechanically correct, but I don't think this release should be cut. Two blocking issues, both about the fork's release wiring rather than the diff.
🔴 Critical — 0.3.7 is already released; this publish cannot succeed
Blockcast/designer is a fork of pro-vi/designer, currently 1 ahead / 79 behind upstream main. Upstream has already shipped this version:
| Fact | Value |
|---|---|
Upstream tag v0.3.7 |
commit a67be0d4134885e5f44093b280568fea872e5a06 |
@pro-vi/designer@0.3.7 on npm |
published 2026-05-25, gitHead a67be0d4… (same commit) |
npm dist-tags.latest |
0.3.24 |
| Upstream latest tag | v0.3.24 |
Merging this cuts a fork-local v0.3.7 tag pointing at a different commit than the 0.3.7 that was actually released, for a version number that is 17 releases stale.
Then release-publish.yml runs npm publish --provenance --access public against @pro-vi/designer@0.3.7. npm does not allow republishing an existing version, so that step fails with a 403 — leaving a tag and a GitHub release behind with no artifact, and a red workflow. Note also that the package name belongs to the upstream @pro-vi scope, not to this fork.
The Verify version matches tag step in release-publish.yml won't catch this: it only compares package.json to the tag, and those agree. Nothing checks the version against what's already on the registry.
🟠 Important — this release PR has no CI signal at all
Verified against the API:
actions/runs?branch=release-please--branches--main--components--designer→total_count: 0- runs with
head_sha == bc0ef1fc7b…→ 0 - for contrast, PR #4's branch (
chore/lockfile-refresh) does produceciandDockerruns
ci.yml triggers on pull_request: branches: [main], which this PR matches, so the trigger config isn't the problem. The most likely cause is GitHub's recursion prevention: events produced by secrets.GITHUB_TOKEN — which release-please.yml passes to release-please-action@v4 — do not start new workflow runs.
That matters because release-please.yml's own comment makes the human merge the gate ("the PR is the human's 'yes, this is worth a version'"). Right now that gate has zero automated verification behind it: nothing typechecks, builds, or runs the clean-room install smoke on the commit being released.
Probable knock-on (flagging as likely, not confirmed): the same rule should also stop a GITHUB_TOKEN-created release from firing release-publish.yml's on: release: [published]. Consistent with that, this fork has 5 tags but zero GitHub releases. So merging may quietly no-op rather than publish — which is a different failure than the 403 above, but not a better one. I haven't observed a release being created here, so treat this one as inference.
The standard fix for both is to give release-please-action a PAT or GitHub App token instead of GITHUB_TOKEN.
🟡 Minor — the changelog is misattributed and its links are dead
- The
0.3.7section aggregates ~40 commits spanning the entire pre-fork history — work already shipped upstream in v0.3.0–v0.3.5 — because the fork has no priorCHANGELOG.mdor matching tag to use as a baseline. Self-correcting on later runs, but this entry claims credit for three releases' worth of work. - The compare link
compare/v0.3.6...v0.3.7404s: nov0.3.6tag exists in this fork. Present tags arev0.3.0,v0.3.2,v0.3.3,v0.3.4,v0.3.5— bothv0.3.1andv0.3.6are absent, though.release-please-manifest.jsonclaimed0.3.6. - Issue links
#18–#25were rewritten toBlockcast/designerURLs, but those are upstream numbers. This fork's highest issue/PR number is4, so every one of those links 404s.
✅ What is correct
The version bump is internally consistent across all four files: .release-please-manifest.json, package.json, and both the root and packages[""] entries in package-lock.json (lockfileVersion 3). The patch bump — rather than a minor, despite the feat: entries — correctly reflects bump-patch-for-minor-pre-major: true in release-please-config.json.
Suggested path
The underlying question is whether this fork should be running release automation at all. Either:
- Disable
release-please.ymlandrelease-publish.ymlin the fork — most likely correct ifBlockcast/designertracks upstream and isn't meant to publish to npm; or - Re-sync with upstream (79 commits behind) and version forward from
0.3.24under a package name this fork owns, so releases can't collide with@pro-vi.
Happy to re-review once the direction is picked.
🤖 I have created a release beep boop
0.3.7 (2026-05-20)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.