Skip to content

windows-installer.yml has built nothing since client/ was deleted (0.5.189, #471) — its UberJar step fails on every main push and the run still reads success #562

Description

@emooreatx

.github/workflows/windows-installer.yml runs on every push to main and every tag (and on PRs under ci:full). Its first real step, Build CIRIS Desktop UberJar, does cd client && ./gradlew :desktopApp:packageUberJarForCurrentOS. client/ was deleted in 0.5.189 (#471 — the client is the ciris-client[node] PyPI package now), so the step has failed on every run since, every downstream step (wheel, PyInstaller, Inno Setup) is skipped, and no Windows installer has been produced since that cut.

The run-level conclusion still shows success on main and on tags (the job fails, the run does not), so nothing surfaced it. It surfaced on PR #561 only because ci:full runs the job on a PR, where the rollup shows the job's own conclusion: FAILURE.

Evidence: main run 34154975707 (ed2ccb5) — job Windows desktop installer: failure, step Build CIRIS Desktop UberJar: failure (cd: client: No such file or directory), every later step skipped; same shape on v0.5.201 run 34154993444 and on 34145707043.

What #561 does: disables the job with the reason in the file so a ci:full PR reads truthfully. What this issue asks: decide whether the Windows desktop installer is still a deliverable — if yes, rebuild the job around the PyPI client (pip install ciris-client[node] into the PyInstaller bundle instead of the vendored Gradle tree); if no, delete the workflow.

🤖 Generated with Claude Code

https://claude.ai/code/session_0132ELwj5JU6t4jEKpwH9bJ7

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions