London | 26-ITP-May | Remi M. | Sprint 3 | Implement and Rewrite

[remimarcelle]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide
• Run npm test from root - all tests pass
• No console.assert errors in output
• getCardValue throws errors for invalid inputs e.g. "invalid" and "1♠"
• All 6 angle type cases covered including boundaries

Changelist

• Implemented getAngleType, isProperFraction and getCardValue with JSDoc and console.assert tests
• Rewrote all three sets of tests using Jest syntax covering normal, boundary and invalid cases

Questions

• I used inline assertion style for exercises 2 and 3 and variable style for exercise 1 to match the existing example in the file - is there a preferred style?
• For getCardValue I had to change slice(0, -2) to slice(0, -1) as the suit symbols were being read differently on Windows - is this the right fix?

[remimarcelle]

remimarcelle/My-Coursework-Planner#70