You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Parameters looks almost like an immutable native representation of the union of input parameters and defaults for unspecified parameters but violates this for:
Physics_Parameters::chemical_potential_
...
We'd all benefit from parameters clearly containing the immutable run parameters such that it can be serialized to output hdf5 to unambiguous run parameters for reproducibility and reduce possibilities of difficult to find state related bugs.
We need to gather information and ideally resolve this in the future.
I suggest a clear separation between immutable for run parameters and updating parameters of a run.
The DCALoopData seems like a likely place for the mutable parameters to be managed.
Parameters looks almost like an immutable native representation of the union of input parameters and defaults for unspecified parameters but violates this for:
We'd all benefit from parameters clearly containing the immutable run parameters such that it can be serialized to output hdf5 to unambiguous run parameters for reproducibility and reduce possibilities of difficult to find state related bugs.
Code that depends on this immutability:
We need to gather information and ideally resolve this in the future.
I suggest a clear separation between immutable for run parameters and updating parameters of a run.
The
DCALoopDataseems like a likely place for the mutable parameters to be managed.