Skip to content

Clear the red style gate blocking devtools::test #179

Description

@jurjoroa

Goal

tests/testthat/test_style.R:24 fails because lintr::expect_lint_free() finds 16 lints in shipped source — 15 return_linter and 1 trailing_whitespace_linter — so devtools::test() cannot reach green while the other v1.1.0 fixes are being verified. .lintr additionally disables cyclocomp_linter, which is no longer part of lintr's defaults and emits a warning on every run.

Scope

  • Resolve the 15 return_linter lints across ceac.R, create_sa.R, evsi.R, exp_loss.R, gen_psa_samp.R, icers.R, metamodel.R, owsa.R, psa.R and the affected test file
  • Remove the single trailing_whitespace_linter lint
  • Drop the stale cyclocomp_linter = NULL entry from .lintr
  • Confirm devtools::test() reports 0 failures and 0 warnings

Acceptance

lintr::lint_package() returns only the 64 vignette object_usage_linter false positives, and devtools::test() is green — establishing the trustworthy baseline the other six v1.1.0 fixes are verified against.


Version: #172

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions