You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
calculate_icers()'s nstrat == 1 early return at R/icers.R:80-83 skips the Status column, the column ordering and the class assignment, so it hands back a bare data.frame instead of an icers object. plot() then dispatches to plot.data.frame and fails with need finite 'ylim' values.
Scope
At R/icers.R:80-83, set Status to "ND", assign Inc_Cost/Inc_Effect/ICER as NA, reorder to the same 7-column layout as the multi-strategy return, and set class(df) <- c("icers", "data.frame")
Add a regression test asserting the single-strategy return has class icers and the same columns in the same order as a multi-strategy return
Add a regression test asserting plot() on a single-strategy result returns a ggplot object
Goal
calculate_icers()'snstrat == 1early return atR/icers.R:80-83skips theStatuscolumn, the column ordering and theclassassignment, so it hands back a baredata.frameinstead of anicersobject.plot()then dispatches toplot.data.frameand fails withneed finite 'ylim' values.Scope
R/icers.R:80-83, setStatusto"ND", assignInc_Cost/Inc_Effect/ICERasNA, reorder to the same 7-column layout as the multi-strategy return, and setclass(df) <- c("icers", "data.frame")icersand the same columns in the same order as a multi-strategy returnplot()on a single-strategy result returns aggplotobjectnstrat == 0guard in the same blockVersion: #172