Skip to content

ButtonGroup and ButtonMenu Should Pass "theme" Prop Down #40

Description

@machineghost

ButtonGroup and ButtonMenu components can already pass down a size property to their buttons, so:

<ButtonGroup size="sm">
  <Button>Foo</Button>
  <Button>Bar</Button>
</ButtonGroup>

is the same as:

<ButtonGroup>
  <Button size="sm">Foo</Button>
  <Button size="sm">Bar</Button>
</ButtonGroup>

In the same fashion, it would be nice if you could set "theme" on a group/menu, so that (for instance) if you wanted a group of dark buttons you could do so with:

<ButtonGroup theme="dark">
  <Button>Foo</Button>
  <Button>Bar</Button>
</ButtonGroup>

This seems like it would be simple enough to add, so I could potentially submit a PR if desired.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions