Skip to content

feat: CI - Add code rules checking action#3914

Open
arng40 wants to merge 119 commits into
developfrom
feat/dudes/add-code-rules
Open

feat: CI - Add code rules checking action#3914
arng40 wants to merge 119 commits into
developfrom
feat/dudes/add-code-rules

Conversation

@arng40
Copy link
Copy Markdown
Contributor

@arng40 arng40 commented Nov 18, 2025 •
edited
Loading

This PR aim to create a new CI Target in order to ensure the use of the internal tool in geos and to promote the best coding practice.
First, this PR set up the CI check_code_rules and will ensure the use of : stdMap, stdUnorderedMap& stdVector
This PR will be merged after :

@arng40 arng40 self-assigned this Nov 18, 2025
@arng40 arng40 added type: CI Concerns github workflows or generic CI DO NOT MERGE ! flag: no rebaseline Does not require rebaseline labels Nov 18, 2025
MelReyCG
MelReyCG requested changes Mar 12, 2026
View reviewed changes
Comment thread src/coreComponents/mesh/generators/VTKFaceBlockUtilities.cpp Outdated
Comment thread src/coreComponents/mesh/unitTests/testGraphColoring.cpp Outdated
@arng40 arng40 removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Mar 17, 2026
@castelletto1 castelletto1 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Apr 15, 2026
@castelletto1 castelletto1 requested a review from bd713 as a code owner April 15, 2026 06:28
@MelReyCG MelReyCG self-requested a review May 18, 2026 12:34
@MelReyCG MelReyCG removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels May 20, 2026
@MelReyCG
Copy link
Copy Markdown
Contributor

MelReyCG commented May 20, 2026

No issue on CUDA nor integrated tests, disabling flags.

@MelReyCG MelReyCG added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkachuma dkachuma dkachuma approved these changes

@MelReyCG MelReyCG MelReyCG approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner

@victorapm victorapm Awaiting requested review from victorapm victorapm is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner

@herve-gross herve-gross Awaiting requested review from herve-gross

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner

@jafranc jafranc Awaiting requested review from jafranc jafranc is a code owner

@bd713 bd713 Awaiting requested review from bd713 bd713 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@arng40 arng40

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: CI Concerns github workflows or generic CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arng40 @MelReyCG @jafranc @dkachuma @castelletto1 @bd713