Skip to content

Move relperm driver#4040

Open
dkachuma wants to merge 24 commits into
developfrom
dkachuma/refactor/rel-perm-driver
Open

Move relperm driver#4040
dkachuma wants to merge 24 commits into
developfrom
dkachuma/refactor/rel-perm-driver

Conversation

@dkachuma
Copy link
Copy Markdown
Contributor

@dkachuma dkachuma commented Apr 24, 2026

Building on the constitutive testing infrastructure established in PR3883, this pull request moves the RelpermDriver use the same framework.

  • Updates the driver to inherit from ConstitutiveDriver rather than directly from TaskBase.
  • Automatically handles saturation sweeps for 2-phase and 3-phase models, ensuring the sum of saturations remains valid (<= 1.0) for 3-phase evaluations.
  • Introduces a historicalSaturations XML parameter to correctly test drainage and imbibition departure curves by populating historical extremum phase volume fractions.
  • Consolidates related input files into inputFiles/constitutiveDriver/, adds new ATS integration tests for various model types (Table, Brooks-Corey, van Genuchten), and provides full Sphinx documentation alongside a working XML example.
  • Adds sphinx documentation for the relative permeability driver.

@dkachuma dkachuma self-assigned this Apr 24, 2026
@dkachuma dkachuma added type: feature New feature or request type: documentation ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: requires rebaseline Requires rebaseline branch in integratedTests changes XML input ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels May 22, 2026
@dkachuma dkachuma marked this pull request as ready for review May 22, 2026 21:49
@dkachuma dkachuma marked this pull request as draft May 23, 2026 15:32
@dkachuma dkachuma marked this pull request as ready for review May 23, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes XML input ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: documentation type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants