From 591627645e95eaf6bb454c53c4b6ff9b3f0d310c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mustafa=20G=C3=B6kp=C4=B1nar?= Date: Fri, 27 Feb 2026 11:51:44 +0300 Subject: [PATCH] Fix and Refactor frequency combo box population into a dedicated method and update language combo box options to use hardcoded strings, consolidating their setup. --- gk-healter/src/ui.py | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/gk-healter/src/ui.py b/gk-healter/src/ui.py index 1745d7e..866e747 100644 --- a/gk-healter/src/ui.py +++ b/gk-healter/src/ui.py @@ -424,20 +424,14 @@ def _apply_translations_inner(self) -> None: self.lbl_disk_threshold_title.set_text(_("settings_disk_threshold")) self.lbl_last_maintenance_title.set_text(_("settings_last_maintenance")) - # Combo Frequency items (manual translation) - active_freq = self.combo_frequency.get_active_id() - self.combo_frequency.remove_all() - self.combo_frequency.append("7", _("freq_7")) - self.combo_frequency.append("30", _("freq_30")) - self.combo_frequency.append("180", _("freq_180")) - self.combo_frequency.append("365", _("freq_365")) - self.combo_frequency.set_active_id(active_freq) + # Combo Frequency items + self._update_frequency_labels() # Sync combo items self.combo_language.remove_all() - self.combo_language.append("auto", _("lang_auto")) - self.combo_language.append("tr", _("lang_tr")) - self.combo_language.append("en", _("lang_en")) + self.combo_language.append("auto", "Auto") + self.combo_language.append("tr", "Türkçe") + self.combo_language.append("en", "English") self.combo_language.set_active_id(self.settings_manager.get("language")) # About Dialog @@ -760,10 +754,7 @@ def _init_settings_ui(self) -> None: """Populate combo-boxes and restore saved values into the Settings page.""" sm = self.settings_manager - # Language combo (these stay untranslated – they are language names) - self.combo_language.append("auto", "Auto") - self.combo_language.append("en", "English") - self.combo_language.append("tr", "Türkçe") + # Language combo current_lang = sm.get("language") or "auto" self.combo_language.set_active_id(current_lang)