From c3e54869e434d3d8514fef075443a37dc8b73a46 Mon Sep 17 00:00:00 2001
From: Adam Legg <adam.legg@gmail.com>
Date: Sat, 23 May 2026 20:53:19 -0400
Subject: [PATCH 1/2] feat(iap): add plugin native source support to Android
 build templates

Changes:
- AndroidManifest.xml.eex: add com.android.vending.BILLING permission
  for Play Billing (used by mob_iap and any other IAP plugin)
- build.zig.eex: add -Dproject_plugin_sources option that accepts
  comma-separated name:path pairs, allowing mob_dev to auto-discover
  and compile plugin C sources from deps' priv/native/android/jni/

Refs: https://github.com/GenericJam/mob/pull/27
---
 .../app/src/main/AndroidManifest.xml.eex      |  3 ++
 .../android/app/src/main/jni/build.zig.eex    | 35 +++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex b/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
index 0cbdbfa..95e8d3b 100644
--- a/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
+++ b/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
@@ -54,6 +54,9 @@
     <!-- Haptic feedback -->
     <uses-permission android:name="android.permission.VIBRATE" />
 
+    <!-- In-app purchases (MobIap plugin) -->
+    <uses-permission android:name="com.android.vending.BILLING" />
+
     <!-- Background keep-alive (Mob.Background) -->
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC"
diff --git a/priv/templates/mob.new/android/app/src/main/jni/build.zig.eex b/priv/templates/mob.new/android/app/src/main/jni/build.zig.eex
index 431dbc5..22a7ea7 100644
--- a/priv/templates/mob.new/android/app/src/main/jni/build.zig.eex
+++ b/priv/templates/mob.new/android/app/src/main/jni/build.zig.eex
@@ -75,6 +75,12 @@ pub fn build(b: *std.Build) void {
     // iOS template's `-Denif_keepalive=` arg.
     const enif_keepalive = b.option([]const u8, "enif_keepalive", "Absolute path to generated enif_keepalive.c (empty if none needed)") orelse "";
 
+    // Plugin native C sources (auto-discovered by mob_dev from deps).
+    // Each entry: "name:path" where name is the .o basename and path
+    // is the absolute source path. mob_dev scans priv/native/android/jni/
+    // for .c files and emits `-Dproject_plugin_sources=name:path,...`.
+    const project_plugin_sources = b.option([]const u8, "project_plugin_sources", "Comma-separated name:path pairs for plugin native sources") orelse "";
+
     const target_query = abi_to_target(abi) orelse {
         std.debug.print(
             "ERROR: unsupported -Dabi={s} (expected arm64-v8a or armeabi-v7a)\n",
@@ -231,6 +237,35 @@ pub fn build(b: *std.Build) void {
         }
     }
 
+    // --- Plugin native C sources (auto-discovered from deps) ────────────────
+    // mob_dev scans each dependency for `priv/native/android/jni/*.c` and
+    // passes them as `-Dproject_plugin_sources=name:path,...`. Each .c
+    // file is compiled as a plain C object and linked into lib<app>.so.
+    // Plugin Kotlin files are handled separately by Gradle (copied into
+    // the project's java tree by mob_dev).
+    if (project_plugin_sources.len > 0) {
+        var plug_it = std.mem.splitScalar(u8, project_plugin_sources, ',');
+        while (plug_it.next()) |pair| {
+            if (pair.len == 0) continue;
+            var colon_it = std.mem.splitScalar(u8, pair, ':');
+            const name = colon_it.next() orelse continue;
+            const path = colon_it.next() orelse continue;
+            const obj = addCObject(b, .{
+                .name = name,
+                .source = path,
+                .target = target,
+                .optimize = optimize,
+                .c_flags = c_flags,
+                .otp_dir = otp_dir,
+                .erts_vsn = erts_vsn,
+                .mob_dir = mob_dir,
+            });
+            const install = b.addInstallFile(obj, b.fmt("{s}/{s}.o", .{ abi, name }));
+            c_objects_step.dependOn(&install.step);
+            obj_paths.append(b.allocator, obj) catch @panic("OOM");
+        }
+    }
+
     // Link: zig cc -shared, mirroring CMake's prior target_link_libraries
     // (--gc-sections + --whole-archive bracket around the OTP/crypto static
     // libs + plain libcrypto.a + Android system libs). Returns the cp

From 4f92e9fd96efaf8898527491c7360c6b28b3b25b Mon Sep 17 00:00:00 2001
From: Adam Legg <adam.legg@gmail.com>
Date: Sat, 23 May 2026 22:00:38 -0400
Subject: [PATCH 2/2] docs: explain BILLING permission tradeoff in
 AndroidManifest template

The previous one-line comment didn't capture why the permission is
declared unconditionally vs. gated on a generator flag. Expand it to
document both the rationale (avoid generator complexity) and the
tradeoff (Play Console may warn non-IAP apps about the unused
permission) so users know how to opt out.

Template-only change; no behavior shift.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---
 .../android/app/src/main/AndroidManifest.xml.eex   | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex b/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
index 95e8d3b..b84c4ee 100644
--- a/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
+++ b/priv/templates/mob.new/android/app/src/main/AndroidManifest.xml.eex
@@ -54,7 +54,19 @@
     <!-- Haptic feedback -->
     <uses-permission android:name="android.permission.VIBRATE" />
 
-    <!-- In-app purchases (MobIap plugin) -->
+    <!--
+      In-app purchases (MobIap plugin).
+
+      Declared unconditionally because: (1) it has no runtime cost when
+      the app doesn't use Play Billing, and (2) making it conditional
+      requires either a generator flag or a deps-introspecting template,
+      both of which add complexity for marginal benefit.
+
+      Tradeoff: if your app does NOT integrate IAP, Google Play Console
+      may surface a warning during review noting the declared permission
+      is unused. To remove this declaration for non-IAP apps, delete
+      this `uses-permission` line.
+    -->
     <uses-permission android:name="com.android.vending.BILLING" />
 
     <!-- Background keep-alive (Mob.Background) -->