Monolithic file. over 6k lines of code

[Ben-PH]

I have an inkling to write some FreeCAD addons, and happened to come across this one to start. I notice that the entire implementation is in one 6281 line file.

I didn't want to start making PRs willy-nilly without first checking in with what I have in mind.

1. Put class definitions into dedicated file(s)
2. put setup variables at top of pieMenuStart in something like bootstrap.py
3. move function definitions to dedicated file(s)

• where relevant, move function defs into class methods

4. investigate code groups and organise into helpers
5. get rid of globals where possible (starting with the easy ones)

    settingsTabLayout.insertWidget(0, globalSettingsGroup)
    # settingsTabLayout.insertWidget(1, spinBoxGroup)
    settingsTabLayout.insertWidget(1, experimentalGroup)
    settingsTabLayout.insertWidget(2, exportGroup)
    settingsTabLayout.addStretch(1)
    settingsTabLayout.insertSpacing(3, 42)
    settingsTabLayout.insertLayout(4, layoutGlobalShortcut)

would become something like

    initTabLayout(tabLayoutSpec)

Let me know if you have any requestes about how you want the PRs broight in.

[Grubuntu]

Hi,

The code has indeed become bloated over time. It’s a great idea to refactor it.

It’s a great project. I don’t have much time to work on PieMenu right now, so feel free to do whatever you think is best if it helps improve the development and distribution of PieMenu.

[Ben-PH]

I'll get onto it

[Ben-PH]

I've got an initial effort working. Would you be happy to give me permissions, or would you prefer fork-and-PR?

[luzpaz]

@Grubuntu any chance you can review ?

[Grubuntu]

@luzpaz @Ben-PH
I've gone through the code, and it looks fine to me.

Thank you for your excellent work Ben-PH !