From 47e2325a92028f3a2c46e141358e0bbb736f2f29 Mon Sep 17 00:00:00 2001 From: Tim Dudgeon Date: Thu, 13 Aug 2026 13:43:08 +0100 Subject: [PATCH] chore: drop the unused repository-url and repository-tag keys moldb.yaml was the only Job Definition in the ecosystem carrying these two top-level keys, and nothing has ever read them - no hits in the job decoder, the job operator, the job utilities or the job tester. Both values were also wrong from the day they were written: - repository-url pointed at https://github.com/InformaticsMatters/virtual-screening/moldb.yaml, which 404s. The real path is /blob/main/data-manager/moldb.yaml. - repository-tag claimed '1.0.0', a tag from 2021-06-02. moldb.yaml was not created until 2022-10-05, so the file does not exist at the tag it names. They arrived with the file in d16c539 ("more complete moldb workflows", 2022-10-05) and were never touched again. This is boilerplate that was never correct and never consumed, not a convention that lost its tooling. The intent behind them - recording the fixed point a definition came from - is sound, and is met properly by loading a manifest from a repository tag (see docs/versioning.md in the umbrella repository). A self-referential field inside the definition can only drift from the truth, as these two did. No Job behaviour changes and no Job version is affected: these are file-level keys that nothing read. This clears the live example behind hole 1 in docs/schema-coverage.md, the last of the three blockers preventing the schema's remaining objects from setting 'additionalProperties: false'. Verified with jote 0.14.0 against decoder 2.7.0: manifest-moldb.yaml passes 12/12. Refs InformaticsMatters/squonk2-jobs#8. Co-Authored-By: Claude Opus 5 --- data-manager/moldb.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/data-manager/moldb.yaml b/data-manager/moldb.yaml index 5ad134e..5ca7bc3 100644 --- a/data-manager/moldb.yaml +++ b/data-manager/moldb.yaml @@ -3,8 +3,6 @@ kind: DataManagerJobDefinition kind-version: '2021.1' name: MolDB tools collection: moldb -repository-url: https://github.com/InformaticsMatters/virtual-screening/moldb.yaml -repository-tag: '1.0.0' test-groups: - name: moldb