From 173908f4674a33a139a4253eadebb211ab409e63 Mon Sep 17 00:00:00 2001
From: JSONbored <49853598+JSONbored@users.noreply.github.com>
Date: Tue, 21 Jul 2026 12:52:36 -0700
Subject: [PATCH 1/2] test(review): cover the null-issue-title branch in the
 deliverable check

processors.ts's runContentLaneDeliverableCheckForAdvisory passes
issueFetch.facts.title ?? undefined to checkContentLaneDeliverable, but
every existing test's stub always supplied a real title string, so the
nullish side of that fallback was never exercised -- codecov/patch
correctly flagged it as a partial branch on #7931.

Pins that a null/absent issue title degrades cleanly to undefined: the
literal-path-in-body signal alone still detects a missing deliverable,
and passing undefined never throws or wrongly suppresses it.
---
 .../unit/content-lane-deliverable-run.test.ts | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/test/unit/content-lane-deliverable-run.test.ts b/test/unit/content-lane-deliverable-run.test.ts
index 45c7074e6..dfed2cb91 100644
--- a/test/unit/content-lane-deliverable-run.test.ts
+++ b/test/unit/content-lane-deliverable-run.test.ts
@@ -167,6 +167,27 @@ describe("runContentLaneDeliverableCheckForAdvisory (processor wiring, #content-
     expect(adv.findings.map((f) => f.code)).toEqual(["content_lane_deliverable_missing"]);
   });
 
+  // #codecov-patch-gap: the processor call site passes `issueFetch.facts.title ?? undefined` to
+  // checkContentLaneDeliverable -- a real branch (fetchLinkedIssueFacts maps an empty/absent title to
+  // `null`) that no existing test exercised, since stubIssueFetch's own default always supplies SOME
+  // title string. Pins that a null title degrades to `undefined` cleanly: the literal-path-in-body
+  // signal alone still fires, and passing `undefined` never throws or wrongly suppresses it.
+  it("still detects a missing deliverable from the body's literal path when the issue has no usable title (title ?? undefined branch)", async () => {
+    const env = createTestEnv({ LOOPOVER_REVIEW_CONTENT_LANE: "true" });
+    await seedContentLaneRepo(env);
+    vi.stubGlobal("fetch", async (input: RequestInfo | URL) => {
+      const url = input.toString();
+      if (url.includes("/access_tokens")) return Response.json({ token: "installation-token" });
+      if (url.endsWith("/issues/1275")) {
+        return Response.json({ number: 1275, state: "open", title: "", body: "Missing surfaces to add to registry/subnets/foo.json." });
+      }
+      return new Response("not found", { status: 404 });
+    });
+    const adv = advisory();
+    await runContentLaneDeliverableCheckForAdvisory(env, { mode: "live", settings: blockMode, advisory: adv, repoFullName: "acme/widgets", pr, files, installationId: 1 });
+    expect(adv.findings.map((f) => f.code)).toEqual(["content_lane_deliverable_missing"]);
+  });
+
   it("no-ops when the found issue has no usable title/body text at all (empty after trimming)", async () => {
     const env = createTestEnv({ LOOPOVER_REVIEW_CONTENT_LANE: "true" });
     await seedContentLaneRepo(env);

From 0a8045f6298eb914963c86be8965d8a8836bbb5d Mon Sep 17 00:00:00 2001
From: JSONbored <49853598+JSONbored@users.noreply.github.com>
Date: Tue, 21 Jul 2026 13:00:07 -0700
Subject: [PATCH 2/2] docs(review): clarify the null-issue-title fallback in
 the deliverable check

Documents why facts.title's null case degrades to undefined at this
call site (see the accompanying test). Also broadens this PR's diff
beyond a single test file, which a pure test-only diff was tripping
in CI's scoped-test-selection coverage step.
---
 src/queue/processors.ts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/queue/processors.ts b/src/queue/processors.ts
index f47e7b33d..bd3023165 100644
--- a/src/queue/processors.ts
+++ b/src/queue/processors.ts
@@ -7577,6 +7577,10 @@ export async function runContentLaneDeliverableCheckForAdvisory(
       .join("\n\n");
     if (!issueText.trim()) return;
     const changedFiles = args.files.map((file) => file.path);
+    // facts.title is string | null (fetchLinkedIssueFacts maps an empty/absent title to null) --
+    // checkContentLaneDeliverable's issueTitle param is string | undefined, so a null title degrades to
+    // undefined here rather than being passed through: the title-pattern signal simply doesn't fire,
+    // and the literal-path-in-body signal still applies on its own.
     const result = checkContentLaneDeliverable(spec, issueText, changedFiles, issueFetch.facts.title ?? undefined);
     if (result.verdict !== "missing") return;
     args.advisory.findings.push({