LB_UPLOADS_IMAGE_UPLOAD_URL should remove Web/ ?

[ikke-t]

Hi,

while testing the move of logo and favicon location to /Web/upload/images path I noticed I get double Web in URL in browser while it fails to show the uploaded images. Also now someone in support channel is experiencing the same. I removed the Web/ from:

LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images

and it fixed the error. Also it fixed the error from the person in chat. I haven't dig into code why there is Web there and why shouldn't it be, but I know removing it fixes the problem. So perhaps we should remove it from both podman and docker examples?

What do you think? I dunno why it is ok in reservations, but I assume the logo code actually writes the script_url part in there, where as the reservations don't.

[colisee]

If I set LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images, then the picture I assign to the resource is no longer displayed (see screenshot below) and I can see the following error in the web browser console log: manage_resources.php:683 GET http://localhost:8080/uploads/images/resource41782811835.jpg 403 (Forbidden).

[colisee]

@ikke-t : I didn't follow the whole discussion on custom favicons in the upstream github repo. Could you please tell me:

1. Where you put your custom favicon (full path)
2. Which php code looks for your custom favicon

[ikke-t]

╰─⠠⠵ podman exec -ti librebooking-app ls -la Web/uploads/images
total 24
drwxr-xr-x. 1 10034    root    86 Jun 28 09:11 .
drwxrwxr-x. 1 www-data root    22 Jun 17 08:19 ..
-rw-r--r--. 1 10034    root 15406 Jun 28 09:11 custom-favicon.ico
-rw-r--r--. 1 10034    root  8070 Jun 28 09:11 custom-logo.png
-rwxrwxr-x. 1 10034    root     0 Jun 17 08:17 index.html

This is where they go now. Actually it's rewritten by John now.

I believe you can see here from his commit how it handles upload now: LibreBooking/librebooking@99b8409#diff-57e9b7cab301698cafc4c0af2837c4bcf2291b16a8437044316de5a89ead9519

            $imageUploadDirectory = new ImageUploadDirectory();
            $uploadDir = $imageUploadDirectory->GetDirectory();
            $target = $uploadDir . '/custom-logo.' . $logoFile->Extension();

Presenters/Admin/ManageThemePresenter.php, in my git fork.

I had to wipe my db, so I don't have any resource images, so I didn't notice the problem you get.

[inDane]

I have experienced the same with a fresh install via docker compose. Uploading a custom image will result in a 404 on ../Web/Web/uploads/images/custom-logo.png.
Removing Web from LB_UPLOADS_IMAGE_UPLOAD_URL solves this.
LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images

Edit: Version 5.2.0

[ikke-t]

I just tested a couple days old development version which has the fixed upload mechanism in place. I verified it works for me uploading images on OpenShift. Earlier I verified it on podman. It works for me with Web/ removed like said.

Quick fix is to fix the variable. Proper fix would be to check in code why is there need for two different image urls in first place, and unify the code and end up with just one variable for the image paths.

[colisee]

I ran again my test with environment variables LB_UPLOADS_IMAGE_UPLOAD_URL set to uploads/images and it still cannot display the image I assign to the resource.

I confirm that I have the latest librebooking/librebooking:5.2.0 image and I am running from Windows 11 (I will later run the same test from debian:trixie)

[inDane]

That is odd.

EDIT: Both tests with:
librebooking/librebooking:5.2.0

Working Example:

in my lb.env
LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images

From config web page:

Image is shown:

Non Working Example

LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images

image is not shown:

[ikke-t]

BTW be aware the config page shows wrong values if you specify the settings in ENV. So it does not read what the env says, it rather shows something random.

[colisee]

docker compose --file docker-compose-local.yml exec app sh -c 'env | grep LB':

LB_DATABASE_HOSTSPEC=db
LB_LOGGING_SQL=false
LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images
LB_DATABASE_PASSWORD=db_user_pwd
LB_DATABASE_USER=lb_user
LB_LOGGING_FOLDER=/var/log/librebooking
LB_INSTALL_PASSWORD=app_install_pwd
LB_DATABASE_NAME=librebooking
LB_LOGGING_LEVEL=DEBUG
LB_DEFAULT_TIMEZONE=Europe/Zurich
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=uploads/reservation

Print screen from the configuration/uploads section

[colisee]

docker compose --file docker-compose-local.yml exec app sh -c 'cat .htaccess':

RewriteEngine On
# Set RewriteBase if your physical path is different from the URL. For example, if using an alias

# Uncomment the following two lines to force HTTPS
#RewriteCond %{HTTPS} off
#RewriteRule .* https://%{HTTP_HOST}%{REQUEST_URI} [L,R=301]

# Redirect requests that are not already under /Web to /Web.
RewriteCond %{REQUEST_URI} !^/Web(/|$)
RewriteRule ^(.*)$ /Web/$1 [R=301,L]

#Header Set Access-Control-Allow-Origin "*"
#Header add Access-Control-Allow-Headers "origin, x-requested-with, content-type"
#Header add Access-Control-Allow-Methods "PUT, GET, POST, DELETE, OPTIONS"
#php_value max_input_vars 10000

[inDane]

This is with the "Non working example" mentioned earlier.

@colisee In your lb.env, does it say LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images ?
If so, then it is weird that it does not apply it correctly. Do you have a .env that is maybe overriding it?

Because the example lb.env from the repo has it with Web/... but your docker compose --file docker-compose-local.yml exec app sh -c 'env | grep LB' doesnt reflect that.

docker compose --file docker-compose-local.yml exec app sh -c 'env | grep LB'

LB_DATABASE_HOSTSPEC=db
LB_LOGGING_SQL=false
LB_UPLOADS_IMAGE_UPLOAD_URL=Web/uploads/images
LB_DATABASE_PASSWORD=REDACTED
LB_DATABASE_USER=lb_user
LB_LOGGING_FOLDER=/var/log/librebooking
LB_INSTALL_PASSWORD=REDACTED
LB_DATABASE_NAME=librebooking
LB_LOGGING_LEVEL=ERROR
LB_DEFAULT_TIMEZONE=Europe/Berlin
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=Web/uploads/reservation

---

docker compose --file docker-compose-local.yml exec app sh -c 'cat .htaccess'

RewriteEngine On
# Set RewriteBase if your physical path is different from the URL. For example, if using an alias

# Uncomment the following two lines to force HTTPS
#RewriteCond %{HTTPS} off
#RewriteRule .* https://%{HTTP_HOST}%{REQUEST_URI} [L,R=301]

# Redirect requests that are not already under /Web to /Web.
RewriteCond %{REQUEST_URI} !^/Web(/|$)
RewriteRule ^(.*)$ /Web/$1 [R=301,L]

#Header Set Access-Control-Allow-Origin "*"
#Header add Access-Control-Allow-Headers "origin, x-requested-with, content-type"
#Header add Access-Control-Allow-Methods "PUT, GET, POST, DELETE, OPTIONS"
#php_value max_input_vars 10000

[colisee]

@inDane: I did my latest test, using a clone of your fork. I just changed file .examples/docker/lb.envto read LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images. From windows powershell

PS C:\Users\Robin\temp\indane\.examples\docker> cat lb.env
LB_INSTALL_PASSWORD=app_install_pwd
LB_DATABASE_PASSWORD=db_user_pwd
LB_DATABASE_NAME=librebooking
LB_DATABASE_USER=lb_user
LB_DATABASE_HOSTSPEC=db
LB_LOGGING_FOLDER=/var/log/librebooking
LB_LOGGING_LEVEL=DEBUG
LB_LOGGING_SQL=false
LB_DEFAULT_TIMEZONE=Europe/Zurich
LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images
LB_UPLOADS_RESERVATION_ATTACHMENT_PATH=uploads/reservation

Obviously, I ran docker compose --file docker-compose-local.yml down --volumes prior to restart the stack with the modified lb.env file

[colisee]

I may have found something.

At the root of the upstream project tree structure, there is a directory named uploads. If I rename that uploads directory into something else, then it looks like setting LB_UPLOADS_IMAGE_UPLOAD_URL=uploads/images or unsetting this environment variable works as you describe...

@JohnVillalovos : what is the purpose of the uploads directory at the root of the project tree structure?