Skip to content

Consider removing logging.basicConfig() from library code #112

@x-EricH-x

Description

@x-EricH-x

Hi, thank you for the great project.

I noticed that the library currently calls logging.basicConfig(), which configures the root logger.

It would prevent users' call to logging.basicConfig() from taking effects unless force=True is passed.

According to the Python logging HOWTO,
libraries are advised to not log to the root logger and to not add any handlers other than NullHandler.

Thank You,
Eric

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions