Pebble: typescript build fails with "Cannot find module 'web/websocket'"

[imax9000]

Build environment: Linux
Moddable SDK version: 7b68560 (included here as a submodule)
Target device: Pebble Time 2

Description
Attempting to use TypeScript results in build failures.

Steps to Reproduce

docker run --rm -it ubuntu:latest

# inside the container
export TZ=Etc/UTC
ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
export PATH=/usr/local/bin:/root/.local/bin:$PATH

apt update
apt install -y pipx npm
pipx install --python 3.12 --fetch-missing-python pebble-tool
npm install -g typescript

pebble new-project --alloy test
cd test
mv src/embeddedjs/main.{js,ts}
pebble build -v

Expected behavior
Successful build.

Actual behavior

Running Moddable prebuild.
Running mcrun -m ./src/embeddedjs/manifest.json -f x -p pebble/emery -t build -o ./build/mods/emery/mcrun -s tech.moddable.pebble
### -p pebble/emery
# tsc main.ts
../../../root/.local/share/pebble-sdk/SDKs/4.9.169/toolchain/moddable/typings/pebble/global.d.ts:89:40 - error TS2307: Cannot find module 'web/websocket' or its corresponding type declarations.

89 declare const WebSocket: typeof import('web/websocket').default;
                                          ~~~~~~~~~~~~~~~


Found 1 error in ../../../root/.local/share/pebble-sdk/SDKs/4.9.169/toolchain/moddable/typings/pebble/global.d.ts:89

# typescript compile failure
make: *** [/test/build/mods/emery/mcrun/tmp/pebble/release/embeddedjs/makefile:99: /test/build/mods/emery/mcrun/tmp/pebble/release/embeddedjs/tsc/main/test/src/embeddedjs/main.js] Error 1
Moddable prebuild failed: Command '['mcrun', '-m', './src/embeddedjs/manifest.json', '-f', 'x', '-p', 'pebble/emery', '-t', 'build', '-o', './build/mods/emery/mcrun', '-s', 'tech.moddable.pebble']' returned non-zero exit status 2.

Other information:

Curiously enough, output file is still getting generated (but I can't be confident that it would always generate correctly) and the Makefile is missing .DELETE_ON_ERROR.

[phoddie]

Thanks for the report. I'm able to reproduce the error. What version of TypeScript are you using? tsc --version

[phoddie]

Oh! TypeScript!

This was introduced when making some compatibility changes for Stack-chan, which unintentionally allowed the module specifiers for two different WebSocket clients to collide.

If you don't mind doing a little temporary surgery on your Pebble SDK, edit this file:

~/Library/Application Support/Pebble SDK/SDKs/current/toolchain/moddable/examples/manifest_typings.json

...by removing...

"$(TYPINGS)/web/*"

...from the "*" section of "modules". Then add:

		"url": [
			"$(TYPINGS)/web/url"
		],
		"headers": [
			"$(TYPINGS)/web/headers"
		],
		"fetch": [
			"$(TYPINGS)/web/fetch"
		],
		"webstorage": [
			"$(TYPINGS)/web/webstorage"
		],
		"web/websocket": [
			"$(TYPINGS)/web/websocket"
		],

Please let me know how that goes. Thank you.

[imax9000]

Thanks for the report. I'm able to reproduce the error. What version of TypeScript are you using? tsc --version

The container is already gone, but I believe that npm install -g typescript installs the currently newest version, which right now would be 6.0.3 (and it's the same version I've first encountered the issue on the host machine with).

If you don't mind doing a little temporary surgery on your Pebble SDK, edit this file:

~/Library/Application Support/Pebble SDK/SDKs/current/toolchain/moddable/examples/manifest_typings.json

...by removing...

"$(TYPINGS)/web/*"

...from the "*" section of "modules". Then add:

That seems to work for now, thanks. I couldn't figure out why the generated build/mods/emery/mcrun/tmp/pebble/release/embeddedjs/files/tsconfig-base.json did not list web/websocket despite declare module "web/websocket" in the corresponding .d.ts file (i.e., it's explicitly distinct from websocket in the parent dir).

[phoddie]

Excellent. Thank you for verifying the change. We'll coordinate with the Pebble folks to get that into their next SDK release. At least there's a workaround for now.