From 088ff3a5cfd86e340cd84ef94f048f05f9f720d0 Mon Sep 17 00:00:00 2001 From: d-morrison Date: Mon, 3 Aug 2026 17:22:02 -0700 Subject: [PATCH] docs(review): fix missing-conjunction run-on in gha#400's comments Lands the two non-blocking grammar nits from gha#400's review that were orphaned on the PR branch (the PR squash-merged the pre-nit commit): add 'so' to the '...never issues the command<, so> there is nothing to republish' clause in the changelog fragment and the run-claude-review-attempt header comment. Comment/changelog prose only; no behavior change. Co-Authored-By: Claude Opus 4.8 --- .github/actions/run-claude-review-attempt/action.yml | 2 +- changelog.d/fix-duplicate-review-comments.fixed.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/run-claude-review-attempt/action.yml b/.github/actions/run-claude-review-attempt/action.yml index 0b211c4c..6b530ea2 100644 --- a/.github/actions/run-claude-review-attempt/action.yml +++ b/.github/actions/run-claude-review-attempt/action.yml @@ -188,7 +188,7 @@ runs: # the prompt below telling the agent to OUTPUT its review rather than # post it, closes that channel; it also retires the raw-`gh pr # comment`-republishing class (gha#312/#318/#381), since the agent - # never issues the command there is nothing to republish. + # never issues the command, so there is nothing to republish. # # `WebFetch` and `Bash(curl:*)` let the reviewer fetch the rendered # output a repo's `prompt-addendum` may tell it to check the diff diff --git a/changelog.d/fix-duplicate-review-comments.fixed.md b/changelog.d/fix-duplicate-review-comments.fixed.md index df67fc10..967feb99 100644 --- a/changelog.d/fix-duplicate-review-comments.fixed.md +++ b/changelog.d/fix-duplicate-review-comments.fixed.md @@ -5,7 +5,7 @@ review rather than post it -- so the workflow's own "Post review comment" step (`github-actions[bot]`) is the sole poster. This also retires the raw-`gh pr comment`-republishing class (#312, #318, #381): with the tool - denied, the agent never issues the command there was nothing to republish. + denied, the agent never issues the command, so there is nothing to republish. As part of the same change, the prior-review-context fetch and the older-comment collapse step now match the `github-actions[bot]` author the workflow actually posts under (they previously matched `claude[bot]` alone,