Skip to content

i18n gate red: 74 banned t('key', 'fallback') call sites #652

Description

@krisarmstrong

./scripts/i18n/validate.sh fails on stem main, independent of any in-flight work.

✘ 74 fallback pattern(s) t('key', 'string') — banned per I18N_CONVENTIONS

Concentrated in ui/src/components/settings/ and ui/src/components/settings/tests/, e.g.

  • ui/src/components/settings/ReflectorSection.tsx:62t('settings:reflector.title', 'Reflector Profile')
  • ui/src/components/settings/InterfaceSection.tsx:41t('settings:interface.title', 'Interface')
  • ui/src/components/settings/ModeSection.tsx:48t('settings:mode.title', 'Mode')

Fix is per I18N_CONVENTIONS: the key belongs in the locale file, not as a second argument. The inline fallback also silently masks a missing es translation — the ES user gets the English string with no gate failure.

Found while landing the Step 3.5 header convergence; the failures predate it and none touch pages.*.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions