Remove unused cusolver/curand deps from libcuopt - #1830
Draft
ramakrishnap-nv wants to merge 1 commit into
Draft
Conversation
Neither is referenced anywhere in cpp/src, and no RAFT header cuOpt includes (raft/core, raft/linalg's cublas-based ops, raft/random's custom PCG generator, raft/sparse) touches either library. Verified with a full local build: nm -D --undefined-only on the resulting libcuopt.so shows zero cusolver/curand symbols among its 762 undefined dynamic symbols, confirming the compiled binary has no runtime dependency on either. cusolver-dev/libcurand-dev removed from dependencies.yaml (conda environments regenerated via rapids-dependency-file-generator). libcurand-dev and its ignore_run_exports entry removed from conda/recipes/libcuopt/recipe.yaml; cusolver was never explicitly declared there, only inherited transitively via libraft-headers. Out of scope: the cuda_wheels pip/wheel install path (untested by this conda-based validation), and switching libraft-headers to libraft-headers-only (bigger change, needs its own conda-build validation). Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ramakrishnap-nv
added
improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither
cusolvernorcurandis referenced anywhere incpp/src, and no RAFT header cuOpt includes touches either library. Verified with a full local build:nm -D --undefined-onlyon the resultinglibcuopt.soshows zerocusolver/curandsymbols among its 762 undefined dynamic symbols.libcusolver-dev/libcurand-devremoved fromdependencies.yaml(conda environments regenerated).libcurand-devand itsignore_run_exportsentry removed fromrecipe.yaml—cusolverwas never explicitly declared there, only inherited vialibraft-headers.curandwas added deliberately in the past (not just inherited), despite the same zero-usage finding — see git blame on the removedCUDA::curandline (9f241a19, around when the barrier method moved to cuDSS for sparse Cholesky/LDLT) for context worth a second look.Out of scope: the
cuda_wheelspip/wheel install path (separate distribution channel, untested here), and switchinglibraft-headers→libraft-headers-only(bigger change, needs its own conda-build validation).