Skip to content

GitHub private release assets fail to download despite valid PAT access #74

Description

@Noah2024

The title is quite descriptive.
I have a custom plugin sitting inside a private repo. Despite adding a github PAT to the the update.key inside the config, the UserAgents seem to be making unauthenticated requests to a successfully resolved download endpoint.
Plugin is being run on the latest version of Velocity in a docker container, and successfully resolves public plugins perfectly.

proxy-1  | [16:58:03 INFO] [AutoUpdatePlugins]: PostgresWhitelist ---- "https://github.com/MaristMC/VelocityPlugin/releases/latest"
proxy-1  | [16:58:03 INFO] [AutoUpdatePlugins]: [DEBUG] OpenConnection url=https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar, auth=false, ua=Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15
proxy-1  | [16:58:04 WARN] [AutoUpdatePlugins]: Failed to download or extract plugin: https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar
proxy-1  | [16:58:04 INFO] [AutoUpdatePlugins]: [DEBUG] OpenConnection url=https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar, auth=false, ua=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
proxy-1  | [16:58:04 WARN] [AutoUpdatePlugins]: Failed to download or extract plugin: https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar
proxy-1  | [16:58:04 INFO] [AutoUpdatePlugins]: [DEBUG] OpenConnection url=https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar, auth=false, ua=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
proxy-1  | [16:58:04 WARN] [AutoUpdatePlugins]: Failed to download or extract plugin: https://github.com/MaristMC/VelocityPlugin/releases/download/V1.0.0/postgresWhitelist-1.0.0.jar
proxy-1  | [16:58:04 INFO] [AutoUpdatePlugins]: [DEBUG] GitHub asset download failed for /MaristMC/VelocityPlugin - auto-compile disabled.

lmk if you need any other info for debugging

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions