From ea845e3921c30dddfd1a48a174ac7837fd2f0e86 Mon Sep 17 00:00:00 2001 From: Manish Kumar Date: Tue, 11 Aug 2026 00:59:07 -0500 Subject: [PATCH] fix: set DJANGO_DEBUG=false explicitly for workbench + celery-worker Companion to omnibioai-workbench#206, which wires settings.py's DEBUG off this env var (was hardcoded True, unconditional). The DEBUG: "1" that lived here before was vestigial -- settings.py never read that key -- so this also pins production intent explicitly rather than relying solely on settings.py's own default. Emergency/interim piece of #38. SECRET_KEY rotation and ALLOWED_HOSTS narrowing are separate, sequenced follow-up work (analysis posted on the issue) -- not touched here. Verified live against the real workbench + celery-worker containers (rebuilt + recreated) and against public https://workbench.omnibioai.org through the actual Cloudflare Tunnel + nginx-router path -- see #38 for the full verification transcript. Co-Authored-By: Claude Sonnet 5 --- docker-compose.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 51deb91..9168885 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -388,7 +388,9 @@ services: ports: - "${HOST_IP:-0.0.0.0}:8000:8000" environment: - DEBUG: "1" + # issue #38: was DEBUG: "1" -- vestigial, settings.py never read it. + # Now wired to the real env var (omnibioai/settings.py:143), default off. + DJANGO_DEBUG: "false" CSRF_EXTRA_ORIGINS: "http://localhost:5174,http://localhost:8000,http://${HOST_IP:-192.168.86.234}:5174,http://${HOST_IP:-192.168.86.234}:8000" DJANGO_SETTINGS_MODULE: omnibioai.settings DB_HOST: mysql @@ -484,7 +486,9 @@ services: restart: on-failure # image: ghcr.io/omnibioai/omnibioai-app:latest environment: - DEBUG: "1" + # issue #38: was DEBUG: "1" -- vestigial, settings.py never read it. + # Now wired to the real env var (omnibioai/settings.py:143), default off. + DJANGO_DEBUG: "false" CSRF_EXTRA_ORIGINS: "http://localhost:5174,http://localhost:8000,http://${HOST_IP:-192.168.86.234}:5174,http://${HOST_IP:-192.168.86.234}:8000" DJANGO_SETTINGS_MODULE: omnibioai.settings DB_HOST: mysql