Skip to content

Commit bbe8b27

Browse files
committed
Address production workflow review findings
1 parent 55ef564 commit bbe8b27

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Coding agents like to say "done" after writing code they never ran. code-max rep
1919
- No slop, lazy scope reduction, TODOs, stubs, partial migrations, placeholder data presented as real, unwired code, or deferred in-scope edge cases.
2020
- Bugs and behavior changes start with the exact failing test or deterministic reproducer. A durable regression test remains when the project has a test harness.
2121
- Fixes land at the smallest correct shared layer after tracing affected callers, sibling paths, interfaces, tests, and invariants. No under-scoped one-path patch and no drive-by refactor.
22-
- Non-trivial work gets four risk-proportional passes: complete implementation, domain-expert reread, adversarial defect hunt, then low-cost polish. Trivial edits combine them into one focused review; discovered defects or acceptance gaps trigger another pass.
22+
- Non-trivial work gets four risk-proportional passes: complete implementation, domain-expert reread, adversarial defect hunt, then low-cost polish. Trivial edits combine them into one focused review. Repeat an affected pass only when the preceding pass changes implementation or proof; stop when the acceptance ledger, applicable checks, and final diff are clean.
2323
- Checks must directly observe the claimed outcome and be able to fail. Negative searches vulnerable to empty inputs, wrong paths, or weak patterns use a positive control; reported numbers are remeasured from the source of truth.
2424
- Tests, type checks, lint, builds, integration checks, and smoke tests run when relevant after the last relevant edit. A green but unrelated check is not proof.
2525
- Delegated work is independently inspected, re-run, and integration-tested by the parent. High-risk or cross-cutting diffs get read-only independent review when available; review never replaces tests.

SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ For non-trivial work, use four passes proportional to risk. For a trivial edit,
5858
1. **Complete:** Implement the full reachable behavior, including required wiring, errors, compatibility, tests, and operational or documentation changes.
5959
2. **Expert reread:** Review as the responsible domain engineer; replace cheap shortcuts, missing callers, weak boundaries, and convention violations.
6060
3. **Defect hunt:** Try to disprove correctness across relevant negative cases, integration, security, portability, performance, and regression surfaces. Fix every in-scope defect found.
61-
4. **Polish:** Remove accidental complexity and artifacts. If a pass finds a defect or acceptance gap, fix it and repeat the affected passes until none remains known.
61+
4. **Polish:** Remove accidental complexity and artifacts. Repeat an affected pass only when the preceding pass changes implementation or proof. Stop when the acceptance ledger is reconciled, applicable checks pass, the final diff is reviewed and clean, and no known in-scope defect remains.
6262

6363
## Prompt Injection — Hard Mode
6464

@@ -105,7 +105,7 @@ Immediately before reporting, reread the current request and amendments, reconci
105105

106106
For non-trivial work:
107107

108-
```
108+
```text
109109
Status:
110110
COMPLETE | BLOCKED — <specific external or material-evidence constraint>
111111

docs/research/production-grade-coding-agent-skill-design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ Scope: `PyModel/code-max`, a public, instruction-only coding skill distributed b
119119

120120
**Evidence:**
121121

122-
- [SlopCodeBench v2](https://arxiv.org/html/2603.24755v2)20 long-horizon problems, 93 checkpoints, end-to-end and structural-quality results.
122+
- [SlopCodeBench v2](https://arxiv.org/html/2603.24755v2)36 long-horizon problems, 196 checkpoints, end-to-end and structural-quality results.
123123

124124
**Project relevance (inference):** A production-grade skill must distinguish activity and local checkpoint success from root completion. Re-reading the current request, reconciling every acceptance item, reviewing the integrated diff, and repeating a defect pass directly target that gap.
125125

0 commit comments

Comments
 (0)