Skip to content

Commit 1f2ae4d

Browse files
committed
fix(update): align brew list timeout with file's 5s convention
`_installed_homebrew_version` used a 60s timeout for the local `brew list --versions` query; the file's other local package-state queries (dpkg-query, rpm) use 5s. A local DB read never needs 60s, and a shorter timeout fails fast if brew hangs. Addresses CodeRabbit review.
1 parent df8e239 commit 1f2ae4d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/pythinker_code/ui/shell/update.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ def _installed_homebrew_version() -> str | None:
665665
encoding="utf-8",
666666
errors="replace",
667667
env=get_clean_env(),
668-
timeout=60,
668+
timeout=5,
669669
)
670670
except (OSError, subprocess.SubprocessError):
671671
logger.exception("Failed to read installed Homebrew version:")

0 commit comments

Comments
 (0)