fix(release): keep sdk core pin in lockstep

Author: elkaix

.github/workflows/ci-pythinker-cli.yml

@@ -261,7 +261,8 @@ jobs:
             --root-pyproject pyproject.toml \
             --pythinker-core-pyproject packages/pythinker-core/pyproject.toml \
             --pythinker-host-pyproject packages/pythinker-host/pyproject.toml \
-            --pythinker-review-pyproject packages/pythinker-review/pyproject.toml
+            --pythinker-review-pyproject packages/pythinker-review/pyproject.toml \
+            --pythinker-sdk-pyproject sdks/pythinker-sdk/pyproject.toml
 
       - name: Check pythinker-code version alignment
         if: steps.version.outputs.bump == 'true'

.github/workflows/release-pythinker-cli.yml

@@ -67,7 +67,8 @@ jobs:
             --root-pyproject pyproject.toml \
             --pythinker-core-pyproject packages/pythinker-core/pyproject.toml \
             --pythinker-host-pyproject packages/pythinker-host/pyproject.toml \
-            --pythinker-review-pyproject packages/pythinker-review/pyproject.toml
+            --pythinker-review-pyproject packages/pythinker-review/pyproject.toml \
+            --pythinker-sdk-pyproject sdks/pythinker-sdk/pyproject.toml
 
       # Hard release gate: every PyPI release must ship a matching README +
       # CHANGELOG update. README.md must contain a "What's New in <version>"

scripts/check_pythinker_dependency_versions.py

@@ -46,6 +46,7 @@ def main() -> int:
     parser.add_argument("--pythinker-core-pyproject", type=Path, required=True)
     parser.add_argument("--pythinker-host-pyproject", type=Path, required=True)
     parser.add_argument("--pythinker-review-pyproject", type=Path, required=True)
+    parser.add_argument("--pythinker-sdk-pyproject", type=Path, required=True)
     args = parser.parse_args()
 
     try:
@@ -63,6 +64,7 @@ def main() -> int:
         return 1
 
     errors: list[str] = []
+    package_versions: dict[str, str] = {}
     for name, pyproject_path in (
         ("pythinker-core", args.pythinker_core_pyproject),
         ("pythinker-host", args.pythinker_host_pyproject),
@@ -73,6 +75,7 @@ def main() -> int:
         except ValueError as exc:
             errors.append(str(exc))
             continue
+        package_versions[name] = package_version
 
         pinned_version = find_pinned_dependency(deps, name)
         if pinned_version is None:
@@ -85,6 +88,28 @@ def main() -> int:
                 f"but {pyproject_path} has {package_version}."
             )
 
+    try:
+        sdk_project = load_project_table(args.pythinker_sdk_pyproject)
+    except ValueError as exc:
+        errors.append(str(exc))
+    else:
+        sdk_deps = sdk_project.get("dependencies", [])
+        if not isinstance(sdk_deps, list):
+            errors.append(
+                f"project.dependencies must be a list in {args.pythinker_sdk_pyproject}"
+            )
+        elif core_version := package_versions.get("pythinker-core"):
+            sdk_core_pin = find_pinned_dependency(sdk_deps, "pythinker-core")
+            if sdk_core_pin is None:
+                errors.append(
+                    f"Missing pinned dependency for pythinker-core in {args.pythinker_sdk_pyproject}."
+                )
+            elif sdk_core_pin != core_version:
+                errors.append(
+                    f"pythinker-sdk core dependency mismatch: sdk depends on {sdk_core_pin}, "
+                    f"but {args.pythinker_core_pyproject} has {core_version}."
+                )
+
     if errors:
         for error in errors:
             print(f"error: {error}", file=sys.stderr)

scripts/release.py

@@ -27,6 +27,7 @@
 CORE_PYPROJECT = REPO_ROOT / "packages" / "pythinker-core" / "pyproject.toml"
 HOST_PYPROJECT = REPO_ROOT / "packages" / "pythinker-host" / "pyproject.toml"
 REVIEW_PYPROJECT = REPO_ROOT / "packages" / "pythinker-review" / "pyproject.toml"
+SDK_PYPROJECT = REPO_ROOT / "sdks" / "pythinker-sdk" / "pyproject.toml"
 
 # Single source for the three hand-authored changelog files. validate() asserts
 # the `## Unreleased` anchor in ALL of them before any write, and rewrite()
@@ -206,6 +207,7 @@ def rewrite(target: str, *, bump_core: str | None, bump_host: str | None) -> Non
     if bump_core:
         set_root_version(CORE_PYPROJECT, bump_core)
         set_dependency_pin(ROOT_PYPROJECT, "pythinker-core", bump_core)
+        set_dependency_pin(SDK_PYPROJECT, "pythinker-core", bump_core)
     if bump_host:
         set_root_version(HOST_PYPROJECT, bump_host)
         set_dependency_pin(ROOT_PYPROJECT, "pythinker-host", bump_host)
@@ -247,6 +249,8 @@ def rewrite(target: str, *, bump_core: str | None, bump_host: str | None) -> Non
         "packages/pythinker-host/pyproject.toml",
         "--pythinker-review-pyproject",
         "packages/pythinker-review/pyproject.toml",
+        "--pythinker-sdk-pyproject",
+        "sdks/pythinker-sdk/pyproject.toml",
     ],
     ["uv", "sync", "--frozen", "--all-extras", "--all-packages"],
     ["uv", "run", "pytest", "tests/test_version_lockstep.py", "-q"],

sdks/pythinker-sdk/pyproject.toml

@@ -19,7 +19,7 @@ classifiers = [
     "Topic :: Software Development :: Libraries :: Python Modules",
     "Topic :: Scientific/Engineering :: Artificial Intelligence",
 ]
-dependencies = ["pythinker-core==1.1.1", "mcp>=1.23,<2", "httpx>=0.28.1"]
+dependencies = ["pythinker-core==1.2.0", "mcp>=1.23,<2", "httpx>=0.28.1"]
 
 [project.urls]
 Homepage      = "https://github.com/Pythoughts-labs/pythinker-code"

tests/test_release_py.py

@@ -44,6 +44,12 @@ def test_dep_check_passes_when_review_pin_matches(tmp_path: Path) -> None:
     review = _write(
         tmp_path, "review.toml", '[project]\nname="pythinker-review"\nversion="0.1.0"\n'
     )
+    sdk = _write(
+        tmp_path,
+        "sdk.toml",
+        '[project]\nname="pythinker-sdk"\nversion="1.1.0"\n'
+        'dependencies=["pythinker-core==1.1.1"]\n',
+    )
     result = _run_dep_check(
         "--root-pyproject",
         str(root),
@@ -53,6 +59,8 @@ def test_dep_check_passes_when_review_pin_matches(tmp_path: Path) -> None:
         str(host),
         "--pythinker-review-pyproject",
         str(review),
+        "--pythinker-sdk-pyproject",
+        str(sdk),
     )
     assert result.returncode == 0, result.stderr
 
@@ -70,6 +78,12 @@ def test_dep_check_fails_when_review_pin_drifts(tmp_path: Path) -> None:
     review = _write(
         tmp_path, "review.toml", '[project]\nname="pythinker-review"\nversion="0.2.0"\n'
     )
+    sdk = _write(
+        tmp_path,
+        "sdk.toml",
+        '[project]\nname="pythinker-sdk"\nversion="1.1.0"\n'
+        'dependencies=["pythinker-core==1.1.1"]\n',
+    )
     result = _run_dep_check(
         "--root-pyproject",
         str(root),
@@ -79,11 +93,48 @@ def test_dep_check_fails_when_review_pin_drifts(tmp_path: Path) -> None:
         str(host),
         "--pythinker-review-pyproject",
         str(review),
+        "--pythinker-sdk-pyproject",
+        str(sdk),
     )
     assert result.returncode == 1
     assert "pythinker-review version mismatch" in result.stderr
 
 
+def test_dep_check_fails_when_sdk_core_pin_drifts(tmp_path: Path) -> None:
+    root = _write(
+        tmp_path,
+        "root.toml",
+        '[project]\nname="pythinker-code"\nversion="0.29.0"\n'
+        'dependencies=["pythinker-core[contrib]==1.2.0","pythinker-host==1.0.0",'
+        '"pythinker-review==0.1.0"]\n',
+    )
+    core = _write(tmp_path, "core.toml", '[project]\nname="pythinker-core"\nversion="1.2.0"\n')
+    host = _write(tmp_path, "host.toml", '[project]\nname="pythinker-host"\nversion="1.0.0"\n')
+    review = _write(
+        tmp_path, "review.toml", '[project]\nname="pythinker-review"\nversion="0.1.0"\n'
+    )
+    sdk = _write(
+        tmp_path,
+        "sdk.toml",
+        '[project]\nname="pythinker-sdk"\nversion="1.1.0"\n'
+        'dependencies=["pythinker-core==1.1.1"]\n',
+    )
+    result = _run_dep_check(
+        "--root-pyproject",
+        str(root),
+        "--pythinker-core-pyproject",
+        str(core),
+        "--pythinker-host-pyproject",
+        str(host),
+        "--pythinker-review-pyproject",
+        str(review),
+        "--pythinker-sdk-pyproject",
+        str(sdk),
+    )
+    assert result.returncode == 1
+    assert "pythinker-sdk core dependency mismatch" in result.stderr
+
+
 def test_parse_semver_accepts_xyz() -> None:
     assert release_tool.parse_semver("0.28.0") == (0, 28, 0)
 

tests/test_version_lockstep.py

@@ -13,13 +13,17 @@ def _version(rel: str) -> str:
         return tomllib.load(fh)["project"]["version"]
 
 
-def _root_deps() -> list[str]:
-    with (REPO_ROOT / "pyproject.toml").open("rb") as fh:
+def _deps(rel: str) -> list[str]:
+    with (REPO_ROOT / rel).open("rb") as fh:
         return tomllib.load(fh)["project"]["dependencies"]
 
 
-def _pin(name: str) -> str:
-    for dep in _root_deps():
+def _root_deps() -> list[str]:
+    return _deps("pyproject.toml")
+
+
+def _pin_in(deps: list[str], name: str) -> str:
+    for dep in deps:
         head = dep.split("==", 1)
         if len(head) == 2 and head[0].split("[")[0] == name:
             return head[1].split(";")[0].strip()
@@ -39,10 +43,20 @@ def test_subpackage_pins_match_versions() -> None:
     assert _pin("pythinker-review") == _version("packages/pythinker-review/pyproject.toml")
 
 
+def _pin(name: str) -> str:
+    return _pin_in(_root_deps(), name)
+
+
 def test_review_is_frozen_at_0_1_0() -> None:
     assert _pin("pythinker-review") == "0.1.0"
 
 
+def test_sdk_core_pin_matches_core_version() -> None:
+    assert _pin_in(_deps("sdks/pythinker-sdk/pyproject.toml"), "pythinker-core") == _version(
+        "packages/pythinker-core/pyproject.toml"
+    )
+
+
 def test_readme_heading_and_pip_snippet() -> None:
     readme = (REPO_ROOT / "README.md").read_text(encoding="utf-8")
     assert f"What's New in {VERSION}" in readme