fix(windows): address updater review comments

Author: elkaix

README.md

@@ -195,7 +195,7 @@ installs to `%ProgramFiles%\Pythinker` and writes PATH to HKLM (requires admin).
 
 **Upgrade:** `pythinker update` from inside the running app — it downloads
 the newest installer, verifies SHA-256, and launches the signed Inno installer
-with visible progress (`/SILENT /NORESTART /CLOSEAPPLICATIONS /NORESTARTAPPLICATIONS`).
+with visible progress (`/SILENT /NORESTART /CURRENTUSER /CLOSEAPPLICATIONS /NORESTARTAPPLICATIONS`).
 
 **Uninstall:** Apps & Features → *Pythinker Code* → Uninstall reverts both
 the files and the PATH edit.

docs/public/install.ps1

@@ -198,14 +198,14 @@ try {
   OK "Checksum OK"
 
   Step "Running Pythinker installer"
-  $args = @(
+  $installerArgs = @(
     '/SILENT',
     '/NORESTART',
     '/CURRENTUSER',
     '/CLOSEAPPLICATIONS',
     '/NORESTARTAPPLICATIONS'
   )
-  $process = Start-Process -FilePath $installerPath -ArgumentList $args -Wait -PassThru
+  $process = Start-Process -FilePath $installerPath -ArgumentList $installerArgs -Wait -PassThru
   if ($process.ExitCode -ne 0) {
     Fail "installer exited with code $($process.ExitCode)"
   }

packages/windows-installer/build.ps1

@@ -99,12 +99,17 @@ if (-not $SkipInstaller) {
     }
     $isccArgs = @("/DAppVersion=$Version")
     if ($signingConfigured) {
-        $signCommand = "powershell.exe -NoProfile -NonInteractive -File `"$signScript`" `$f"
+        # Keep quoted paths out of /SPythinkerSign itself. Windows PowerShell 5.1
+        # can mangle nested quotes when passing native arguments to iscc.exe.
+        $env:PYTHINKER_INNO_SIGN_SCRIPT = "`"$signScript`""
+        $signCommand = 'cmd.exe /D /C powershell.exe -NoProfile -NonInteractive -File %PYTHINKER_INNO_SIGN_SCRIPT% $f'
         $isccArgs += "/SPythinkerSign=$signCommand"
         $isccArgs += "/DUseInnoSignTool=1"
     }
     $isccArgs += (Join-Path $here 'installer.iss')
 
+    Write-Host "build.ps1: invoking Inno Setup with arguments:"
+    foreach ($arg in $isccArgs) { Write-Host "  $arg" }
     & $iscc.Source @isccArgs
     if ($LASTEXITCODE -ne 0) { throw "Inno Setup compile failed ($LASTEXITCODE)" }
 }

scripts/install.ps1

@@ -198,14 +198,14 @@ try {
   OK "Checksum OK"
 
   Step "Running Pythinker installer"
-  $args = @(
+  $installerArgs = @(
     '/SILENT',
     '/NORESTART',
     '/CURRENTUSER',
     '/CLOSEAPPLICATIONS',
     '/NORESTARTAPPLICATIONS'
   )
-  $process = Start-Process -FilePath $installerPath -ArgumentList $args -Wait -PassThru
+  $process = Start-Process -FilePath $installerPath -ArgumentList $installerArgs -Wait -PassThru
   if ($process.ExitCode -ne 0) {
     Fail "installer exited with code $($process.ExitCode)"
   }

src/pythinker_code/ui/shell/update.py

@@ -53,6 +53,7 @@
 LAST_SEEN_VERSION_FILE = get_share_dir() / "last_seen_version.txt"
 AUTO_UPDATE_CHECK_INTERVAL_SECONDS = 24 * 60 * 60
 PROMPT_UPDATE_REFRESH_TIMEOUT_SECONDS = 2.0
+WINDOWS_UPDATE_STAGING_MAX_AGE_SECONDS = 7 * 24 * 60 * 60
 
 _UPDATE_LOCK = asyncio.Lock()
 _skipped_version_this_session: str | None = None
@@ -782,7 +783,13 @@ def _windows_native_installer_args() -> list[str]:
     ``/SILENT`` still avoids the wizard, but leaves normal installer UI/errors
     visible and delegates app-closing to Inno Setup's Restart Manager.
     """
-    return ["/SILENT", "/NORESTART", "/CLOSEAPPLICATIONS", "/NORESTARTAPPLICATIONS"]
+    return [
+        "/SILENT",
+        "/NORESTART",
+        "/CURRENTUSER",
+        "/CLOSEAPPLICATIONS",
+        "/NORESTARTAPPLICATIONS",
+    ]
 
 
 def _spawn_detached_windows_installer(installer_path: Path) -> bool:
@@ -1004,9 +1011,6 @@ def _install_native_archive(archive: Path) -> UpdateResult:
     return UpdateResult.UPDATED
 
 
-WINDOWS_UPDATE_STAGING_MAX_AGE_SECONDS = 7 * 24 * 60 * 60
-
-
 def _windows_update_staging_parent() -> Path:
     return get_share_dir() / "windows-update-staging"
 

tests/test_release_update_pipeline.py

@@ -78,8 +78,15 @@ def test_windows_installer_signs_update_artifacts_when_credentials_are_available
     # wired for the frozen executable, bundled DLL/PYD files, and Inno's
     # setup/uninstaller/temp copies.
     assert "@('.exe', '.dll', '.pyd')" in build_script
+    assert "PYTHINKER_INNO_SIGN_SCRIPT" in build_script
+    assert (
+        "cmd.exe /D /C powershell.exe -NoProfile -NonInteractive "
+        "-File %PYTHINKER_INNO_SIGN_SCRIPT% $f"
+    ) in build_script
+    assert '-File `"$signScript`"' not in build_script
     assert "/SPythinkerSign=$signCommand" in build_script
     assert "/DUseInnoSignTool=1" in build_script
+    assert "build.ps1: invoking Inno Setup with arguments:" in build_script
 
 
 def test_release_asset_wait_covers_all_updater_channels() -> None:

tests/ui_and_conv/test_native_update_parity.py

@@ -152,6 +152,7 @@ def fake_popen(args, **kwargs):
         str(installer),
         "/SILENT",
         "/NORESTART",
+        "/CURRENTUSER",
         "/CLOSEAPPLICATIONS",
         "/NORESTARTAPPLICATIONS",
     ]

tests/ui_and_conv/test_shell_update.py

@@ -766,6 +766,7 @@ def fake_popen(args, **kwargs):
                 str(installer),
                 "/SILENT",
                 "/NORESTART",
+                "/CURRENTUSER",
                 "/CLOSEAPPLICATIONS",
                 "/NORESTARTAPPLICATIONS",
             ],

web/public/install.ps1

@@ -198,14 +198,14 @@ try {
   OK "Checksum OK"
 
   Step "Running Pythinker installer"
-  $args = @(
+  $installerArgs = @(
     '/SILENT',
     '/NORESTART',
     '/CURRENTUSER',
     '/CLOSEAPPLICATIONS',
     '/NORESTARTAPPLICATIONS'
   )
-  $process = Start-Process -FilePath $installerPath -ArgumentList $args -Wait -PassThru
+  $process = Start-Process -FilePath $installerPath -ArgumentList $installerArgs -Wait -PassThru
   if ($process.ExitCode -ne 0) {
     Fail "installer exited with code $($process.ExitCode)"
   }