test(tui): tighten markdown review guards

Author: elkaix

docs/superpowers/plans/2026-05-29-tui-markdown-report-contract-hardening.md

@@ -6,7 +6,7 @@
 
 **Architecture:** Lead phase of `docs/superpowers/specs/2026-05-29-tui-renderer-contract-hardening-design.md`. We do **not** build a renderer. We add Tier-1 contract tests (capture + assertion) under `tests/ui_and_conv/`, characterize the existing regex repair pipeline (pin, don't refactor), ground report tests in the real 92-finding fixture, and apply exactly one source fix (AST-based report-fence extraction in `report.py`) gated by a failing test.
 
-**Tech Stack:** Python 3.12+, Rich 15, prompt_toolkit 3, markdown-it-py, pytest (`asyncio_mode = auto`), `uv`. Run tests with `uv run pytest …` (fallback: `.venv/bin/python -m pytest …`).
+**Tech Stack:** Python 3.12+, Rich 15, prompt_toolkit 3, markdown-it-py, pytest (`asyncio_mode = auto`), `uv`. Run tests with `uv run pytest …`.
 
 **Spec reference:** `docs/superpowers/specs/2026-05-29-tui-renderer-contract-hardening-design.md` §6–§8.
 
@@ -748,14 +748,16 @@ def render_agent_body(text: str, *, theme: ThemeName | None = None) -> Renderabl
     report block renders via :func:`render_report`; an invalid or nested block is
     left in place so the surrounding markdown shows it as an ordinary code block.
     """
-    lines = text.splitlines(keepends=True)
+    # Split on "\n" only: markdown-it's token.map counts only "\n", so
+    # splitlines() can desync fence delimiter indices on other line separators.
+    lines = text.split("\n")
     segments: list[RenderableType] = []
     cursor = 0  # line index
     for start, end, payload in _iter_report_payloads(text):
         report = parse_report_block(payload)
         if report is None:
             continue  # malformed — leave it for the markdown renderer
-        before = "".join(lines[cursor:start]).strip("\n")
+        before = "\n".join(lines[cursor:start]).strip("\n")
         if before:
             segments.append(pythinker_markdown(before))
         segments.append(render_report(report, theme=theme))
@@ -764,7 +766,7 @@ def render_agent_body(text: str, *, theme: ThemeName | None = None) -> Renderabl
     if not segments:
         return pythinker_markdown(text)
 
-    rest = "".join(lines[cursor:]).strip("\n")
+    rest = "\n".join(lines[cursor:]).strip("\n")
     if rest:
         segments.append(pythinker_markdown(rest))
 

tests/ui_and_conv/test_md_color_contract.py

@@ -35,8 +35,14 @@ def test_code_block_border_does_not_use_inline_code_color():
     # The rounded frame characters must not carry the inline-code foreground.
     inline_fg = _sgr_fg(colors.inline_code)
     for frame_char in ("╭", "╰", "─"):
-        idx = coloured.find(frame_char)
-        if idx == -1:
-            continue
-        window = coloured[max(0, idx - 24) : idx]
-        assert inline_fg not in window, "border frame inherited inline-code color"
+        found_count = 0
+        start = 0
+        while True:
+            idx = coloured.find(frame_char, start)
+            if idx == -1:
+                break
+            found_count += 1
+            window = coloured[max(0, idx - 24) : idx]
+            assert inline_fg not in window, "border frame inherited inline-code color"
+            start = idx + 1
+        assert found_count > 0, f"missing expected frame glyph {frame_char!r}"

tests/ui_and_conv/test_md_render_authority.py

@@ -28,11 +28,11 @@ def test_no_direct_terminal_writes_in_renderer(filename):
             func = node.func
             if isinstance(func, ast.Name) and func.id == "print":
                 offenders.append(f"print() at line {node.lineno}")
-            if (
-                isinstance(func, ast.Attribute)
-                and func.attr == "write"
-                and isinstance(func.value, ast.Attribute)
-                and func.value.attr in {"stdout", "stderr"}
-            ):
-                offenders.append(f"std*.write at line {node.lineno}")
+            if isinstance(func, ast.Attribute) and func.attr == "write":
+                target = func.value
+                is_std_stream = (
+                    isinstance(target, ast.Attribute) and target.attr in {"stdout", "stderr"}
+                ) or (isinstance(target, ast.Name) and target.id in {"stdout", "stderr"})
+                if is_std_stream:
+                    offenders.append(f"std*.write at line {node.lineno}")
     assert not offenders, f"{filename} bypasses the screen model: {offenders}"

tests/ui_and_conv/test_md_stream_idempotency.py

@@ -32,12 +32,10 @@ def test_streaming_table_is_not_committed_mid_row():
     # stream character-by-character to maximize the chance of a mid-table commit
     committed = _drain(list(full))
     # No committed slice may end in the middle of the table (i.e. contain the
-    # delimiter row but not the closing blank line + following block).
+    # delimiter row but not the data row that completes this fixture's table).
     for slice_ in committed[:-1]:
         if "---" in slice_:
-            assert slice_.rstrip().endswith("|") is False or "After" in "".join(committed), (
-                "a partial table row was committed before the table closed"
-            )
+            assert "| 1 | 2 |" in slice_, "a header-only table was committed before data arrived"
     # Reassembled stream equals the original (no loss, no duplication).
     assert "".join(committed) == full
 

tests/ui_and_conv/test_md_table_contract.py

@@ -37,7 +37,8 @@ def test_table_with_escaped_pipes_keeps_literal_pipe():
     """Bug class: escaped pipe must render as a literal '|', not split a cell."""
     md = "| Col |\n| --- |\n| a \\| b |\n"
     out = render_plain(pythinker_markdown(md), width=80)
-    assert "a | b" in out or "a \\| b" not in out  # literal pipe preserved
+    assert "a | b" in out  # literal pipe preserved
+    assert "a \\| b" not in out
     assert "Col" in out