fix(tui): preserve simultaneous right-side toast and address review findings

- Carry left and right toasts separately in FooterViewModel so a right-side
  toast is no longer dropped when a left toast is active (regression from the
  footer unification).
- Log clipboard read failures at debug before returning None.
- Drop the unused is_clipboard_available re-export from prompt.py.
- Split side-effecting append() calls out of assert statements in history tests.

Author: elkaix

src/pythinker_code/ui/shell/prompt.py

@@ -96,9 +96,6 @@
 from pythinker_code.ui.shell.prompting.clipboard import (
     grab_media_from_clipboard as grab_media_from_clipboard,
 )
-from pythinker_code.ui.shell.prompting.clipboard import (
-    is_clipboard_available as is_clipboard_available,
-)
 from pythinker_code.ui.shell.prompting.clipboard import (
     is_media_clipboard_available as is_media_clipboard_available,
 )
@@ -3960,8 +3957,6 @@ def _build_footer_view_model(self, columns: int) -> FooterViewModel:
         ):
             command_line = runner.current_line
 
-        left_toast = self._prompt_toast("left")
-        toast_snapshot = left_toast if left_toast is not None else self._prompt_toast("right")
         update_provider = cast(
             Callable[[], str | None] | None,
             getattr(self, "_update_notice_provider", None),
@@ -3978,8 +3973,9 @@ def _build_footer_view_model(self, columns: int) -> FooterViewModel:
                 bash=background_counts.bash,
                 agent=background_counts.agent,
             ),
-            toast=toast_snapshot,
+            toast=self._prompt_toast("left"),
             update_notice=update_provider() if callable(update_provider) else None,
+            toast_right=self._prompt_toast("right"),
         )
 
     def _update_notice_for_render(self) -> str | None:
@@ -4091,14 +4087,14 @@ def _get_one_rotating_tip(self) -> str | None:
         return self._tips[self._tip_rotation_index % len(self._tips)]
 
     def _render_right_span(self, footer: FooterViewModel) -> str:
-        if footer.toast is None or footer.toast.position != "right":
+        if footer.toast_right is None:
             status = footer.status
             return format_context_status(
                 status.context_usage,
                 status.context_tokens,
                 status.max_context_tokens,
             )
-        return footer.toast.message
+        return footer.toast_right.message
 
 
 # Compatibility surface kept for tests that still import the legacy footer

src/pythinker_code/ui/shell/prompting/clipboard.py

@@ -20,6 +20,7 @@
 from pythinker_code.utils.clipboard import (
     is_media_clipboard_available as utility_is_media_clipboard_available,
 )
+from pythinker_code.utils.logging import logger
 
 
 class ClipboardAdapter:
@@ -54,7 +55,8 @@ def paste_text(self, clipboard: Clipboard) -> str | None:
         """Return pasted text, preserving the prompt's silent failure behavior."""
         try:
             data = clipboard.get_data()
-        except Exception:
+        except Exception as exc:
+            logger.debug("Clipboard text read failed: error={!r}", exc)
             return None
         return data.text
 

src/pythinker_code/ui/shell/prompting/footer.py

@@ -23,6 +23,10 @@ class FooterViewModel:
     background_summary: str
     toast: ToastSnapshot | None
     update_notice: str | None
+    # Left- and right-positioned toasts can be active at once; the right toast is
+    # rendered by the right span, so it must be carried separately from ``toast``
+    # (which feeds left-side content precedence) or it would be dropped.
+    toast_right: ToastSnapshot | None = None
 
 
 @dataclass(frozen=True, slots=True)

tests/ui_and_conv/test_footer_view_model.py

@@ -171,6 +171,39 @@ def test_legacy_and_card_adapters_share_left_policy_and_width_safety(
         assert "toast-only" not in _text(card)
 
 
+def test_left_and_right_toasts_both_render(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Regression: a left toast must not drop a simultaneously active right toast."""
+    monkeypatch.setenv("NO_COLOR", "1")
+    session = _session()
+    left = ToastSnapshot(
+        message="left-toast",
+        position="left",
+        style="bold",
+        topic=None,
+        expires_at=float("inf"),
+    )
+    right = ToastSnapshot(
+        message="right-toast",
+        position="right",
+        style="bold",
+        topic=None,
+        expires_at=float("inf"),
+    )
+    model = FooterViewModel(
+        status=_status(120, ascii_only=True),
+        command_line="",
+        extension_statuses=(),
+        background_summary="",
+        toast=left,
+        update_notice=None,
+        toast_right=right,
+    )
+
+    rendered = _text(session._render_legacy_bottom_toolbar(model))
+    assert "left-toast" in rendered
+    assert "right-toast" in rendered
+
+
 def test_footer_view_model_is_immutable_and_width_specific() -> None:
     model = _model(80, command="cached")
     narrower = replace(model, status=replace(model.status, columns=40))

tests/ui_and_conv/test_prompt_history.py

@@ -148,31 +148,38 @@ def test_append_history_entry_restricts_file_permissions(tmp_path) -> None:
 def test_prompt_history_store_loads_only_configured_tail(tmp_path) -> None:
     store = PromptHistoryStore(tmp_path / "history.jsonl", max_entries=2)
 
-    assert store.append("one")
-    assert store.append("two")
-    assert store.append("three")
+    appended_one = store.append("one")
+    appended_two = store.append("two")
+    appended_three = store.append("three")
+    assert appended_one
+    assert appended_two
+    assert appended_three
 
     assert [entry.content for entry in store.load()] == ["two", "three"]
 
 
 def test_prompt_history_store_excludes_credential_commands(tmp_path) -> None:
     store = PromptHistoryStore(tmp_path / "history.jsonl")
 
-    assert store.append("/login api-key") is False
-    assert store.append("logout openai") is False
+    login_appended = store.append("/login api-key")
+    logout_appended = store.append("logout openai")
+    assert login_appended is False
+    assert logout_appended is False
     assert not store.path.exists()
 
 
 def test_prompt_history_store_skips_oversized_records(tmp_path) -> None:
     store = PromptHistoryStore(tmp_path / "history.jsonl")
 
-    assert store.append("x" * (256 * 1024)) is False
+    oversized_appended = store.append("x" * (256 * 1024))
+    assert oversized_appended is False
     assert not store.path.exists()
 
 
 def test_prompt_history_store_clear_confirms_both_files_are_removed(tmp_path) -> None:
     store = PromptHistoryStore(tmp_path / "history.jsonl")
-    assert store.append("kept")
+    kept_appended = store.append("kept")
+    assert kept_appended
     encoding = "utf-8"
     store.rotated_path.write_text('{"content":"older"}\n', encoding=encoding)
 
@@ -196,7 +203,8 @@ def test_prompt_history_clear_reports_success_only_after_confirmed_removal(
     monkeypatch,
 ) -> None:
     store = PromptHistoryStore(tmp_path / "history.jsonl")
-    assert store.append("kept")
+    kept_appended = store.append("kept")
+    assert kept_appended
     prompt_session = object.__new__(shell_prompt.CustomPromptSession)
     cast(Any, prompt_session)._history_store = store
     app = SimpleNamespace(_prompt_session=prompt_session)