Skip to content

Commit c408206

Browse files
committed
fix(typo): toggleable, edge_diagnostic
Fix the two repo-wide spellcheck failures flagged by the typos CI gate: 'togglable' -> 'toggleable' in a test comment, and 'ede_diagnostic' -> 'edge_diagnostic' in a planning note.
1 parent ad278cd commit c408206

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

tasks/reference-adoption-catalog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ The honest read: the reference is overwhelmingly already-present or stubbed, not
165165
- **Reference evidence:** query_engine.py:227-256 (_is_result_successful, docstring 'ported, not stubbed True' at line 234); 712-732 (consumed to emit error_during_execution)
166166
- **Current evidence:** src/pythinker_code/soul/pythinkersoul.py:190 StepStopReason classifies WHY it stopped (no_tool_calls/tool_rejected/stuck) but TurnOutcome (:338) carries no success/failure quality bit; grep for is_result_successful/result_successful/error_during_execution/degenerate_terminal in src/ returns nothing; ui/print/__init__.py:83,88 returns SUCCESS on any clean completion, FAILURE only from exceptions at :440-451 — a stuck/empty terminal still exits 0
167167
- **Reference liveness:** live
168-
- **Adoption sketch:** Add a boolean degenerate_terminal to TurnOutcome (pythinkersoul.py:338) computed at the no_tool_calls exit (~:1828/:1920) from the final assistant_message content emptiness against pythinker's Message/TextPart model (NOT the reference content-block dicts; reconstruct, never copy the literal ede_diagnostic string). Keep it OBSERVATIONAL first: emit a telemetry attribute on the turn span (pythinkersoul.py:1187) before gating exit codes, to avoid false-positives on legitimate tool-only-then-stop turns. Once tuned, ui/print/__init__.py (~:448) can map an empty terminal to a non-zero exit / distinct error_type. Medium risk because the empty-terminal definition must be tuned against real tool-only completions.
168+
- **Adoption sketch:** Add a boolean degenerate_terminal to TurnOutcome (pythinkersoul.py:338) computed at the no_tool_calls exit (~:1828/:1920) from the final assistant_message content emptiness against pythinker's Message/TextPart model (NOT the reference content-block dicts; reconstruct, never copy the literal edge_diagnostic string). Keep it OBSERVATIONAL first: emit a telemetry attribute on the turn span (pythinkersoul.py:1187) before gating exit codes, to avoid false-positives on legitimate tool-only-then-stop turns. Once tuned, ui/print/__init__.py (~:448) can map an empty terminal to a non-zero exit / distinct error_type. Medium risk because the empty-terminal definition must be tuned against real tool-only completions.
169169
- **Surgical scope:** src/pythinker_code/soul/pythinkersoul.py (TurnOutcome + terminal classification) + ui/print/__init__.py (exit-code mapping); focused test; M
170170

171171
#### `project-context-as-separate-user-reminder` — Project/env context injected as a separate <system-reminder> user message rather than baked into the immutable system array

tests/ui_and_conv/test_settings_selector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def test_settings_exposes_auto_update_toggle_when_live(monkeypatch):
213213
item = _item(_build_settings_config(config), "auto_update")
214214

215215
assert item is not None
216-
assert item.values == ("true", "false") # togglable
216+
assert item.values == ("true", "false") # toggleable
217217
assert item.current_value == "true"
218218

219219

0 commit comments

Comments
 (0)