fix(approval): preserve newer deliberation generations

Author: elkaix

src/pythinker_code/soul/approval.py

@@ -284,9 +284,11 @@ def deliberation_gate(self, tool_call: ToolCall) -> str | None:
         # a subagent's identical call from consuming the main agent's one-shot (state is
         # shared via Approval.share()).
         prior_generation = self._state.deliberated_fingerprints.get(fingerprint)
-        if prior_generation is not None and prior_generation < generation:
-            del self._state.deliberated_fingerprints[fingerprint]
-            return None
+        if prior_generation is not None:
+            if prior_generation < generation:
+                del self._state.deliberated_fingerprints[fingerprint]
+                return None
+            return reason
         self._state.deliberated_fingerprints[fingerprint] = generation
         return reason
 

tests/core/test_approval_auto.py

@@ -185,6 +185,8 @@ def test_older_generation_duplicate_destructive_call_still_bounces() -> None:
         assert approval.deliberation_gate(_shell_call("rm -rf build")) is not None
     with deliberation_scope("root", 1):
         assert approval.deliberation_gate(_shell_call("rm -rf build")) is not None
+    with deliberation_scope("root", 2):
+        assert approval.deliberation_gate(_shell_call("rm -rf build")) is not None
 
 
 def test_deliberation_gate_conditions() -> None: