Skip to content

Commit 019e4d0

Browse files
committed
fix: make desktop release shell explicit
Run desktop package configuration with Bash on both platform jobs so Windows does not interpret Bash environment variables with PowerShell. Add a release workflow regression gate for both configuration steps.
1 parent ff0582f commit 019e4d0

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/desktop-release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ jobs:
171171
- run: pnpm install --frozen-lockfile
172172

173173
- name: Configure desktop release
174+
shell: bash
174175
env:
175176
DESKTOP_CHANNEL: ${{ needs.prepare.outputs.channel }}
176177
DESKTOP_VERSION: ${{ needs.prepare.outputs.version }}
@@ -355,6 +356,7 @@ jobs:
355356
- run: pnpm install --frozen-lockfile
356357
357358
- name: Configure desktop release
359+
shell: bash
358360
env:
359361
DESKTOP_CHANNEL: ${{ needs.prepare.outputs.channel }}
360362
DESKTOP_VERSION: ${{ needs.prepare.outputs.version }}

scripts/release/release-workflows.test.mjs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ import test from 'node:test';
66
const root = resolve(import.meta.dirname, '../..');
77
const read = (path) => readFileSync(resolve(root, path), 'utf8');
88

9+
void test('desktop releases configure both platforms with Bash', () => {
10+
const workflow = read('.github/workflows/desktop-release.yml');
11+
const configuredWithBash = workflow.match(/^ - name: Configure desktop release\n shell: bash$/gmu);
12+
assert.equal(configuredWithBash?.length ?? 0, 2);
13+
});
14+
915
void test('release workflow uses full push-boundary lane signals and isolated jobs', () => {
1016
const workflow = read('.github/workflows/release.yml');
1117
const desktopJob = workflow.slice(

0 commit comments

Comments
 (0)