fix(telemetry): emit the pfc_ event prefix the ingest service routes on (#181)

## Related Issue

No issue — found while auditing the telemetry path before cutting a
release.

## Problem

The telemetry ingest service selects crash reports by an exact event
name and its
dashboards query events by prefix. The client was emitting a different
prefix than
the one the service routes on, so:

- every crash report was silently dropped at ingest instead of reaching
the error tracker;
- ordinary events landed in storage but were invisible to every
dashboard panel;
- crashes were recorded at INFO severity rather than ERROR.

Nothing failed loudly — the ingest endpoint returns `200 {ok:true}`
regardless — so
the client looked healthy while reporting nothing usable.

## What changed

- `packages/telemetry/src/transport.ts` and
`packages/agent-core-v2/src/app/telemetry/cloudTransport.ts` emit the
prefix the
ingest service actually routes on, for both the event name and the
payload user id.
- Both constants now carry JSDoc naming them as a wire contract, so a
future edit has
  to acknowledge what depends on them.
- The existing prefix-locking tests were the mechanism that caught this;
they now
  assert the correct value and fail if either constant drifts again.

Verified: `packages/telemetry` 72/72 and the `packages/agent-core-v2`
telemetry suites
39/39 pass; a repo-wide search finds no remaining use of the old prefix.

[skip changeset] — this fixes an internal reporting path with no
user-visible behavior.

## Checklist

- [x] I have read the
[CONTRIBUTING](https://github.com/PyModel/pythinker-code/blob/main/CONTRIBUTING.md)
document.
- [x] I have linked a related issue (external PRs: the issue must have a
maintainer's `/approve`).
- [x] I have added tests that prove my feature works.
- [x] Ran `gen-changesets` skill, or this PR needs no changeset.
- [x] Ran `gen-docs` skill, or this PR needs no doc update.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Restored telemetry events and active device reporting in observability
dashboards.
- Corrected telemetry identifiers to use the current event and device ID
naming format.

- **Tests**
- Updated telemetry validation to confirm correct event names, user
identifiers, retries, fallbacks, and initialization behavior.

- **Release**
  - Included a patch release for the code package.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: elkaix

.changeset/fix-telemetry-dashboard.md

@@ -0,0 +1,5 @@
+---
+"@pymodel/pythinker-code": patch
+---
+
+Restore telemetry events and active devices in observability dashboards.

packages/agent-core-v2/src/app/telemetry/cloudTransport.ts

@@ -48,8 +48,10 @@ export interface CloudTransportOptions {
 }
 
 export const TELEMETRY_ENDPOINT = 'https://telemetry-logs.pythinker.com/v1/event';
-export const SERVER_EVENT_PREFIX = 'kfc_';
-export const USER_ID_PREFIX = 'kfc_device_id_';
+/** Do not change this Pythinker wire prefix. SigNoz dashboards query `pfc_*` events. */
+export const SERVER_EVENT_PREFIX = 'pfc_';
+/** Do not change this Pythinker identity prefix. SigNoz device queries depend on it. */
+export const USER_ID_PREFIX = 'pfc_device_id_';
 export const DISK_EVENT_MAX_AGE_MS = 7 * 24 * 60 * 60 * 1000;
 export const RETRY_BACKOFFS_MS = [1_000, 4_000, 16_000] as const;
 

packages/agent-core-v2/test/app/telemetry/cloudAppender.test.ts

@@ -96,9 +96,9 @@ describe('CloudAppender', () => {
 
     expect(requests).toHaveLength(1);
     expect(requests[0]?.url).toBe('https://telemetry-logs.pythinker.com/v1/event');
-    expect(requests[0]?.body.user_id).toBe('kfc_device_id_dev123');
+    expect(requests[0]?.body.user_id).toBe('pfc_device_id_dev123');
     const event = requests[0]?.body.events[0];
-    expect(event?.['event']).toBe('kfc_tool.call');
+    expect(event?.['event']).toBe('pfc_tool.call');
     expect(event?.['device_id']).toBe('dev123');
     expect(event?.['session_id']).toBe('sess1');
     expect(event?.['property_name']).toBe('bash');

packages/telemetry/src/transport.ts

@@ -14,8 +14,10 @@ import type { EnrichedTelemetryEvent, TelemetryPrimitive } from './types';
 import { isTelemetryPrimitive } from './types';
 
 export const TELEMETRY_ENDPOINT = 'https://telemetry-logs.pythinker.com/v1/event';
-export const SERVER_EVENT_PREFIX = 'kfc_';
-export const USER_ID_PREFIX = 'kfc_device_id_';
+/** Do not change this Pythinker wire prefix. SigNoz dashboards query `pfc_*` events. */
+export const SERVER_EVENT_PREFIX = 'pfc_';
+/** Do not change this Pythinker identity prefix. SigNoz device queries depend on it. */
+export const USER_ID_PREFIX = 'pfc_device_id_';
 export const DISK_EVENT_MAX_AGE_MS = 7 * 24 * 60 * 60 * 1000;
 export const RETRY_BACKOFFS_MS = [1_000, 4_000, 16_000] as const;
 

packages/telemetry/test/telemetry.test.ts

@@ -410,7 +410,7 @@ describe('payload assembly', () => {
   it('adds server event prefix, payload user id, and flattened fields', () => {
     const payload = buildPayload([sampleEvent('started')], 'device-1');
 
-    expect(payload.user_id).toBe('kfc_device_id_device-1');
+    expect(payload.user_id).toBe('pfc_device_id_device-1');
     expect(payload.events[0]).toMatchObject({
       event_id: 'event-1',
       device_id: 'device-1',
@@ -426,9 +426,9 @@ describe('payload assembly', () => {
   });
 
   it('does not double-prefix already-prefixed events', () => {
-    const payload = buildPayload([sampleEvent('kfc_started')], 'device-1');
+    const payload = buildPayload([sampleEvent('pfc_started')], 'device-1');
 
-    expect(payload.events[0]?.['event']).toBe('kfc_started');
+    expect(payload.events[0]?.['event']).toBe('pfc_started');
   });
 
   it('rejects nested property values before outbound send', () => {
@@ -484,7 +484,7 @@ describe('payload assembly', () => {
     const payload = buildPayload([event], 'device-1');
 
     expect(payload.events[0]).toMatchObject({
-      event: 'kfc_nullable',
+      event: 'pfc_nullable',
       property_empty: null,
     });
     expect(event.properties).toBe(originalProperties);
@@ -495,8 +495,8 @@ describe('payload assembly', () => {
 
 describe('server prefix application', () => {
   it('locks the outbound telemetry prefixes', () => {
-    expect(SERVER_EVENT_PREFIX).toBe('kfc_');
-    expect(USER_ID_PREFIX).toBe('kfc_device_id_');
+    expect(SERVER_EVENT_PREFIX).toBe('pfc_');
+    expect(USER_ID_PREFIX).toBe('pfc_device_id_');
   });
 
   it('returns a new object only when adding the server prefix', () => {
@@ -505,12 +505,12 @@ describe('server prefix application', () => {
     const prefixed = applyServerPrefix(event);
 
     expect(prefixed).not.toBe(event);
-    expect(prefixed.event).toBe('kfc_started');
+    expect(prefixed.event).toBe('pfc_started');
     expect(event.event).toBe('started');
   });
 
   it('passes already-prefixed and invalid event names through unchanged', () => {
-    const prefixed = sampleEvent('kfc_started');
+    const prefixed = sampleEvent('pfc_started');
     const emptyName = sampleEvent('');
     const missingName = { ...sampleEvent('missing') } as unknown as Record<string, unknown>;
     delete missingName['event'];
@@ -547,7 +547,7 @@ describe('AsyncTransport', () => {
     const init = requestInitFrom(fetchImpl);
     expect(init.headers).toMatchObject({ Authorization: 'Bearer token-1' });
     expect(JSON.parse(init.body as string)).toMatchObject({
-      user_id: 'kfc_device_id_dev',
+      user_id: 'pfc_device_id_dev',
     });
   });
 
@@ -696,7 +696,7 @@ describe('AsyncTransport', () => {
 
     const init = requestInitFrom(fetchImpl);
     const payload = JSON.parse(init.body as string) as { events: Array<{ event: string }> };
-    expect(payload.events[0]?.['event']).toBe('kfc_from_disk');
+    expect(payload.events[0]?.['event']).toBe('pfc_from_disk');
     expect(() => statSync(file)).toThrow();
   });
 
@@ -790,7 +790,7 @@ describe('AsyncTransport', () => {
       properties: { resumed: false, count: 2 },
     });
     expect(file).not.toContain('user_id');
-    expect(file).not.toContain('kfc_first');
+    expect(file).not.toContain('pfc_first');
   });
 
   it('does not create a disk file for an empty batch or a schema violation', async () => {
@@ -867,7 +867,7 @@ describe('telemetry bootstrap', () => {
       events: Array<{ event: string; session_id: string }>;
     };
     expect(payload.events[0]).toMatchObject({
-      event: 'kfc_before_init',
+      event: 'pfc_before_init',
       session_id: 'ses',
     });
   });