fix(vscode): cap every summary line, not just the multi-line branch

.slice(0, 400) bound to the template literal rather than the conditional, so a
single-line error came back uncapped — a registry answering with one long JSON
line would print unbounded in both the retry warning and the target summary.
Verified before the fix: a 500-character single-line error returned 500, while
the multi-line path already capped at 400.

The limit is now a named constant so the test asserts against it.

Author: elkaix

apps/vscode/scripts/publish-retry.mjs

@@ -8,6 +8,9 @@ const AUTH_PATTERN = /\b401\b|unauthorized|invalidaccess|access denied|not allow
 
 export const DEFAULT_ATTEMPTS = 3;
 
+/** Longest summary line worth printing; registry errors can be one huge JSON blob. */
+export const SUMMARY_LIMIT = 400;
+
 export function messageOf(error) {
   return error instanceof Error ? error.message : String(error);
 }
@@ -27,7 +30,9 @@ export function summaryLine(error) {
     .filter((line) => line !== '');
   if (lines.length === 0) return '';
   const [wrapper, ...rest] = lines;
-  return rest.length === 0 ? wrapper : `${wrapper} ${rest.join(' ')}`.slice(0, 400);
+  // Cap the whole result, not just the joined branch: a registry that answers
+  // with one long JSON line would otherwise print unbounded.
+  return (rest.length === 0 ? wrapper : `${wrapper} ${rest.join(' ')}`).slice(0, SUMMARY_LIMIT);
 }
 
 /**

apps/vscode/test/publish-retry.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it, vi } from 'vitest';
 
 // @ts-expect-error -- plain .mjs build script, no type declarations
-import { classifyError, publishEachTarget, summaryLine, withRetry } from '../scripts/publish-retry.mjs';
+import { classifyError, publishEachTarget, SUMMARY_LIMIT, summaryLine, withRetry } from '../scripts/publish-retry.mjs';
 
 const TARGETS = ['darwin-x64', 'darwin-arm64', 'linux-x64'];
 const FILES = TARGETS.map((target) => `/tmp/${target}.vsix`);
@@ -67,6 +67,13 @@ describe('summaryLine', () => {
     expect(line).toContain('exited with code 1');
   });
 
+  it('caps a long error whether or not it has a second line', () => {
+    // The cap used to bind only to the joined branch, so a registry answering
+    // with one long JSON line printed in full.
+    expect(summaryLine(new Error('x'.repeat(500)))).toHaveLength(SUMMARY_LIMIT);
+    expect(summaryLine(new Error(`wrapper:\n${'y'.repeat(500)}`))).toHaveLength(SUMMARY_LIMIT);
+  });
+
   it('leaves a single-line error alone and survives a blank one', () => {
     expect(summaryLine(new Error('Response code 401 (Unauthorized)')))
       .toBe('Response code 401 (Unauthorized)');