fix(cli): fall back to the environment when a relay flag is blank

A whitespace-only --relay-key or --relay-origin trimmed to an empty
string, which the nullish fallback still treated as a value, so a
configured environment variable was never read.

Author: elkaix

apps/pythinker-code/src/cli/sub/web/remote-control.ts

@@ -28,7 +28,7 @@ export function resolveRelayOrigin(
   explicit?: string,
   env: Readonly<Record<string, string | undefined>> = process.env,
 ): string {
-  const candidate = explicit?.trim() ?? env[REMOTE_CONTROL_RELAY_ENV]?.trim() ?? '';
+  const candidate = explicit?.trim() || env[REMOTE_CONTROL_RELAY_ENV]?.trim() || '';
   if (candidate.length === 0) return REMOTE_CONTROL_RELAY_ORIGIN;
   const url = new URL(candidate);
   if (url.protocol !== 'http:' && url.protocol !== 'https:') {
@@ -46,7 +46,7 @@ export function resolveRelayKey(
   explicit?: string,
   env: Readonly<Record<string, string | undefined>> = process.env,
 ): string {
-  const candidate = explicit?.trim() ?? env[REMOTE_CONTROL_RELAY_KEY_ENV]?.trim() ?? '';
+  const candidate = explicit?.trim() || env[REMOTE_CONTROL_RELAY_KEY_ENV]?.trim() || '';
   if (candidate.length === 0) {
     throw new Error(
       `Remote Control needs a relay key. Pass --relay-key or set ${REMOTE_CONTROL_RELAY_KEY_ENV}.`,

apps/pythinker-code/test/cli/web/remote-control.test.ts

@@ -205,6 +205,11 @@ describe('resolveRelayOrigin', () => {
     expect(resolveRelayOrigin('  ', { PYTHINKER_CODE_REMOTE_CONTROL_RELAY: '  ' })).toBe(
       REMOTE_CONTROL_RELAY_ORIGIN,
     );
+    expect(
+      resolveRelayOrigin('   ', {
+        PYTHINKER_CODE_REMOTE_CONTROL_RELAY: 'https://env.example.test',
+      }),
+    ).toBe('https://env.example.test');
   });
 
   it('rejects a relay that is not http(s)', async () => {
@@ -224,6 +229,9 @@ describe('resolveRelayKey', () => {
       resolveRelayKey(undefined, { PYTHINKER_CODE_REMOTE_CONTROL_RELAY_KEY: 'env-key' }),
     ).toBe('env-key');
     expect(resolveRelayKey('  spaced-key  ', {})).toBe('spaced-key');
+    expect(
+      resolveRelayKey('   ', { PYTHINKER_CODE_REMOTE_CONTROL_RELAY_KEY: 'env-key' }),
+    ).toBe('env-key');
   });
 
   it('refuses to fall back to another credential when no key is given', async () => {