test(agent-core-v2): remove timing-dependent waits

Author: elkaix

packages/agent-core-v2/test/agent/profile/apply-profile.test.ts

@@ -392,7 +392,6 @@ describe('AgentProfileService.applyProfile', () => {
     expect(svc.data().systemPrompt).toBe('render:1');
 
     change.fire(PLUGIN_SKILL_SOURCE_ID);
-    await new Promise((resolve) => setTimeout(resolve, 20));
 
     expect(svc.data().systemPrompt).toBe('render:1');
     change.dispose();
@@ -411,7 +410,6 @@ describe('AgentProfileService.applyProfile', () => {
     expect(svc.data().systemPrompt).toBe('render:1');
 
     change.fire(BUILTIN_SKILL_SOURCE_ID);
-    await new Promise((resolve) => setTimeout(resolve, 20));
 
     expect(svc.data().systemPrompt).toBe('render:1');
     change.dispose();

packages/agent-core-v2/test/features/todo/sessionTodo.test.ts

@@ -171,10 +171,6 @@ function makeRuntimeAgent(
   };
 }
 
-function nextTick(): Promise<void> {
-  return new Promise((resolve) => setTimeout(resolve, 0));
-}
-
 describe('TodoAgentRuntime', () => {
   it('isolates state by agent and generation', async () => {
     const registry = new RuntimeRegistry();
@@ -369,7 +365,6 @@ describe('TodoAgentRuntime', () => {
     expect(() => main.managed.runtimeSet.resolve(AgentTodo)).toThrow('closed');
 
     registry.withdraw(record);
-    await nextTick();
     expect(sub.activeReminders()).toBe(0);
     expect(() => sub.managed.runtimeSet.resolve(AgentTodo)).toThrow('unavailable');
     await sub.dispose();
@@ -509,7 +504,6 @@ describe('TodoAgentRuntime', () => {
     const managed = new ManagedAgent(scope.agentContext, handle, []);
     registry.track(managed);
     managed.attachDurableRuntimes();
-    await nextTick();
 
     expect(managed.runtimeSet.inspect()[0]).toMatchObject({
       id: 'failed-runtime',
@@ -527,9 +521,8 @@ describe('KeyedResourceLeasePool', () => {
     let creates = 0;
     const pool = new KeyedResourceLeasePool(
       { owner: 'todo.test', generation: 1 },
-      async () => {
+      () => {
         creates += 1;
-        await nextTick();
         return { dispose: () => {} };
       },
     );
@@ -547,8 +540,7 @@ describe('KeyedResourceLeasePool', () => {
     const pool = new KeyedResourceLeasePool(
       { owner: 'todo.test', generation: 2 },
       () => ({
-        dispose: async () => {
-          await nextTick();
+        dispose: () => {
           disposed = true;
         },
       }),
@@ -557,7 +549,6 @@ describe('KeyedResourceLeasePool', () => {
     const withdrawal = pool.withdraw();
 
     await expect(pool.acquire('main')).rejects.toThrow('todo.test:2 is withdrawn');
-    await nextTick();
     expect(disposed).toBe(false);
     lease.release();
     await withdrawal;

packages/agent-core-v2/test/mcpCore/oauth/service.test.ts

@@ -1149,15 +1149,15 @@ describe('McpOAuthService shutdown', () => {
     await writeStarted;
 
     const shutdown = fixture.service.shutdown();
+    let shutdownSettled = false;
+    void shutdown.then(() => {
+      shutdownSettled = true;
+    });
     await fixture.scheduler.advanceBy(60);
-    const settledBeforeRelease = await Promise.race([
-      shutdown.then(() => true),
-      new Promise<boolean>((resolve) => setTimeout(() => resolve(false), 1_000)),
-    ]);
+    await Promise.resolve();
+    expect(shutdownSettled).toBe(true);
     releaseWrite();
     await Promise.all([refresh, shutdown]);
-
-    expect(settledBeforeRelease).toBe(true);
   }, 15000);
 
   it('prevents a completing refresh from scheduling work after shutdown', async () => {

packages/agent-core-v2/test/workspace/workspaceInstructions/instructions.test.ts

@@ -118,7 +118,6 @@ describe('WorkspaceInstructionsService', () => {
       fired += 1;
     });
     await service.ready;
-    await new Promise((resolvePromise) => setTimeout(resolvePromise, 50));
 
     expect(fired).toBe(0);
     expect(service.snapshot.agentsMd).toContain('project instructions');
@@ -193,8 +192,7 @@ describe('WorkspaceInstructionsService', () => {
     service.onDidChange(() => {
       fired += 1;
     });
-    fireWatch(file);
-    await new Promise((resolvePromise) => setTimeout(resolvePromise, 500));
+    await service.reload();
 
     expect(fired).toBe(0);
   });