refactor(tui): move the transcript boundary predicates out of the class

Neither predicate reads instance state or touches the UI, so they belong with
the other transcript-component helpers rather than as private methods.

Author: elkaix

apps/pythinker-code/src/tui/pythinker-tui.ts

@@ -93,10 +93,7 @@ import {
 import { StepSummaryComponent } from './components/messages/step-summary';
 import { ThinkingComponent } from './components/messages/thinking';
 import { ToolCallComponent } from './components/messages/tool-call';
-import {
-  ReplayTurnBoundaryComponent,
-  UserMessageComponent,
-} from './components/messages/user-message';
+import { UserMessageComponent } from './components/messages/user-message';
 import { ActivityPaneComponent, type ActivityPaneMode } from './components/panes/activity-pane';
 import { QueuePaneComponent } from './components/panes/queue-pane';
 import type { TuiConfig } from './config';
@@ -175,7 +172,8 @@ import { notifyTerminalOnce } from './utils/terminal-notification';
 import { installTerminalThemeTracking } from './utils/terminal-theme';
 import { detectTmuxKeyboardWarning } from './utils/tmux-keyboard';
 import {
-  getTranscriptComponentEntry,
+  isFoldSegmentBoundaryComponent,
+  isTurnBoundaryComponent,
   markTranscriptComponent,
 } from './utils/transcript-component-metadata';
 import { nextTranscriptId } from './utils/transcript-id';
@@ -2787,34 +2785,6 @@ export class PythinkerTUI {
     this.state.ui.requestRender();
   }
 
-  private isTurnBoundaryComponent(child: Component): boolean {
-    if (
-      !(child instanceof UserMessageComponent) &&
-      !(child instanceof SkillActivationComponent) &&
-      !(child instanceof PluginCommandComponent) &&
-      !(child instanceof ReplayTurnBoundaryComponent)
-    ) {
-      return false;
-    }
-    const entry = getTranscriptComponentEntry(child);
-    if (entry === undefined) return false;
-    // Live user messages / slash activations have an undefined turnId; replayed
-    // ones get a `replay:N` turnId. Both start a new turn. Steer messages carry
-    // a defined non-replay turnId and are not boundaries.
-    return entry.turnId === undefined || entry.turnId.startsWith('replay:');
-  }
-
-  /**
-   * Fold-segment boundary: everything {@link isTurnBoundaryComponent} counts,
-   * plus the cron card. A cron-fired turn mounts no user message, so without
-   * the card as a boundary its output would share the previous user turn's
-   * fold segment - and the completed-turn assistant cap would fold that turn's
-   * final answer into the step summary.
-   */
-  private isFoldSegmentBoundaryComponent(child: Component): boolean {
-    return this.isTurnBoundaryComponent(child) || child instanceof CronMessageComponent;
-  }
-
   private trimTranscriptWindow(): boolean {
     if (!TRANSCRIPT_WINDOW_ENABLED || TRANSCRIPT_MAX_TURNS <= 0) return false;
     // Session replay already caps history to its own turn limit; trimming during
@@ -2828,7 +2798,7 @@ export class PythinkerTUI {
     // the rest of the turn would be left behind.
     const boundaries: number[] = [];
     for (let i = 0; i < children.length; i++) {
-      if (this.isTurnBoundaryComponent(children[i]!)) boundaries.push(i);
+      if (isTurnBoundaryComponent(children[i]!)) boundaries.push(i);
     }
 
     const turns = groupTurns(this.state.transcriptEntries);
@@ -2865,7 +2835,7 @@ export class PythinkerTUI {
     let boundariesSeen = 0;
     let cutoff = 0;
     for (let i = 0; i < children.length; i++) {
-      if (this.isTurnBoundaryComponent(children[i]!)) {
+      if (isTurnBoundaryComponent(children[i]!)) {
         if (boundariesSeen === boundariesToRemove) {
           cutoff = i;
           break;
@@ -2919,7 +2889,7 @@ export class PythinkerTUI {
     // Find the start of the current turn (last turn-starting user message).
     let turnStart = -1;
     for (let i = children.length - 1; i >= 0; i--) {
-      if (this.isFoldSegmentBoundaryComponent(children[i]!)) {
+      if (isFoldSegmentBoundaryComponent(children[i]!)) {
         turnStart = i;
         break;
       }
@@ -3001,7 +2971,7 @@ export class PythinkerTUI {
 
     const boundaries: number[] = [];
     for (let i = 0; i < children.length; i++) {
-      if (this.isFoldSegmentBoundaryComponent(children[i]!)) boundaries.push(i);
+      if (isFoldSegmentBoundaryComponent(children[i]!)) boundaries.push(i);
     }
     if (boundaries.length === 0) return;
 
@@ -3297,7 +3267,7 @@ export class PythinkerTUI {
     // components that have no entry in the metadata map.
     const boundaries: number[] = [];
     for (let i = 0; i < children.length; i++) {
-      if (this.isTurnBoundaryComponent(children[i]!)) boundaries.push(i);
+      if (isTurnBoundaryComponent(children[i]!)) boundaries.push(i);
     }
     const expandCutoff =
       TRANSCRIPT_EXPAND_TURNS <= 0

apps/pythinker-code/src/tui/utils/transcript-component-metadata.ts

@@ -1,5 +1,9 @@
 import type { Component } from '@pymodel/pi-tui';
 
+import { CronMessageComponent } from '../components/messages/cron-message';
+import { PluginCommandComponent } from '../components/messages/plugin-command';
+import { SkillActivationComponent } from '../components/messages/skill-activation';
+import { ReplayTurnBoundaryComponent, UserMessageComponent } from '../components/messages/user-message';
 import type { TranscriptEntry } from '../types';
 
 const componentEntries = new WeakMap<Component, TranscriptEntry>();
@@ -13,3 +17,34 @@ export function getTranscriptComponentEntry(
 ): TranscriptEntry | undefined {
   return componentEntries.get(component);
 }
+
+/**
+ * Turn boundary: the component that starts a new user turn in the transcript.
+ * Live user messages / slash activations have an undefined turnId; replayed
+ * ones get a `replay:N` turnId. Both start a new turn. Steer messages carry a
+ * defined non-replay turnId and are not boundaries.
+ */
+export function isTurnBoundaryComponent(child: Component): boolean {
+  if (
+    !(child instanceof UserMessageComponent) &&
+    !(child instanceof SkillActivationComponent) &&
+    !(child instanceof PluginCommandComponent) &&
+    !(child instanceof ReplayTurnBoundaryComponent)
+  ) {
+    return false;
+  }
+  const entry = getTranscriptComponentEntry(child);
+  if (entry === undefined) return false;
+  return entry.turnId === undefined || entry.turnId.startsWith('replay:');
+}
+
+/**
+ * Fold-segment boundary: everything {@link isTurnBoundaryComponent} counts,
+ * plus the cron card. A cron-fired turn mounts no user message, so without the
+ * card as a boundary its output would share the previous user turn's fold
+ * segment - and the completed-turn assistant cap would fold that turn's final
+ * answer into the step summary.
+ */
+export function isFoldSegmentBoundaryComponent(child: Component): boolean {
+  return isTurnBoundaryComponent(child) || child instanceof CronMessageComponent;
+}