ci: make the desktop package version authoritative and auto-cut its release tag

Desktop 0.2.0 sat on main unreleased while every installed client stayed on
0.1.6: changesets bumps apps/desktop/package.json, but Desktop Release only
fires on a desktop-v* tag and nothing cut one.

- release.yml now cuts desktop-v<version> whenever the version changes on main,
  using the release-bot App token so the tag push actually starts the build.
- desktop-release.yml no longer stamps the tag's version into the tree. The
  package version is the source of truth and a disagreeing tag fails the build,
  so tagging an arbitrary commit can no longer mint an unreviewed release.
- A tagged commit must be an ancestor of main before anything is built.

Author: elkaix

.github/workflows/desktop-release.yml

@@ -33,6 +33,11 @@ jobs:
         with:
           persist-credentials: false
 
+      # apps/desktop/package.json is the single source of truth for the version.
+      # The tag only selects which commit ships. Stamping the tag's version into
+      # the tree instead would let `git tag desktop-v9.9.9 <any commit>` silently
+      # rewrite that commit into a release nobody reviewed, so a disagreement is
+      # a hard failure rather than a rewrite.
       - name: Resolve the desktop version
         id: resolve
         shell: bash
@@ -41,23 +46,43 @@ jobs:
           IS_TAG: ${{ startsWith(github.ref, 'refs/tags/desktop-v') }}
         run: |
           set -euo pipefail
-          # A tag build is authoritative; a manual run falls back to whatever
-          # version the checked-out tree declares.
-          if [ "$IS_TAG" = 'true' ]; then
-            version="${TAG_NAME#desktop-v}"
-          else
-            version="$(node -p 'require("./apps/desktop/package.json").version')"
-          fi
+          version="$(node -p 'require("./apps/desktop/package.json").version')"
           if [ -z "$version" ]; then
             echo 'Could not resolve a desktop version' >&2
             exit 1
           fi
+          if [ "$IS_TAG" = 'true' ]; then
+            tag_version="${TAG_NAME#desktop-v}"
+            if [ "$tag_version" != "$version" ]; then
+              echo "::error::Tag ${TAG_NAME} does not match apps/desktop/package.json (${version})." >&2
+              echo 'Bump the package version on main first, then tag that commit.' >&2
+              exit 1
+            fi
+          fi
           # electron-builder names the GitHub release `v${version}`; the tag we
           # push here (`desktop-v*`) only triggers the workflow.
           echo "version=${version}" >> "$GITHUB_OUTPUT"
           echo "tag=v${version}" >> "$GITHUB_OUTPUT"
           echo "Releasing desktop ${version} as tag v${version}."
 
+      # A release built from a commit that never landed on main ships code no
+      # review gate ever saw. `compare` reports `identical` or `behind` when the
+      # commit is an ancestor of main, and `diverged`/`ahead` when it is not.
+      - name: Require the tagged commit to be on main
+        if: startsWith(github.ref, 'refs/tags/desktop-v')
+        shell: bash
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          set -euo pipefail
+          status="$(gh api "repos/${GITHUB_REPOSITORY}/compare/main...${GITHUB_SHA}" --jq '.status')"
+          case "$status" in
+            identical|behind) echo "${GITHUB_SHA} is on main (${status})." ;;
+            *)
+              echo "::error::${GITHUB_SHA} is not on main (compare status: ${status})." >&2
+              exit 1 ;;
+          esac
+
       - name: Mint releases-repo token
         id: releases_token
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # pinned from v3.2.0
@@ -107,14 +132,6 @@ jobs:
 
       - run: pnpm install --frozen-lockfile
 
-      - name: Stamp desktop version for tag builds
-        if: startsWith(github.ref, 'refs/tags/desktop-v')
-        env:
-          TAG_NAME: ${{ github.ref_name }}
-        run: |
-          export DESKTOP_VERSION="${TAG_NAME#desktop-v}"
-          node -e 'const fs = require("node:fs"); const path = "apps/desktop/package.json"; const packageJson = JSON.parse(fs.readFileSync(path, "utf8")); packageJson.version = process.env.DESKTOP_VERSION; fs.writeFileSync(path, `${JSON.stringify(packageJson, null, 2)}\n`);'
-
       - name: Build workspace
         run: pnpm --workspace-root run build
 
@@ -233,15 +250,6 @@ jobs:
 
       - run: pnpm install --frozen-lockfile
 
-      - name: Stamp desktop version for tag builds
-        if: startsWith(github.ref, 'refs/tags/desktop-v')
-        shell: bash
-        env:
-          TAG_NAME: ${{ github.ref_name }}
-        run: |
-          export DESKTOP_VERSION="${TAG_NAME#desktop-v}"
-          node -e 'const fs = require("node:fs"); const path = "apps/desktop/package.json"; const packageJson = JSON.parse(fs.readFileSync(path, "utf8")); packageJson.version = process.env.DESKTOP_VERSION; fs.writeFileSync(path, `${JSON.stringify(packageJson, null, 2)}\n`);'
-
       - name: Build workspace
         run: pnpm --workspace-root run build
 

.github/workflows/release.yml

@@ -126,6 +126,46 @@ jobs:
           # No NPM_TOKEN on purpose: changesets prefers it over OIDC when set, so
           # defining it would silently downgrade publishing to a long-lived token.
 
+      # apps/desktop is a private workspace package: changesets bumps its
+      # version but nothing publishes it, and Desktop Release only fires on a
+      # `desktop-v*` tag. A bump that nobody tags therefore leaves every
+      # installed desktop client on the previous version with nothing red to
+      # show for it — which is exactly how 0.2.0 sat unreleased behind 0.1.6.
+      # Read both versions out of git rather than the working tree: the
+      # changesets action rewrites package.json in place on the run that opens
+      # the version PR, and that rewrite is not a release.
+      # The App token matters: a tag pushed with GITHUB_TOKEN would not start
+      # Desktop Release, because GitHub refuses to trigger workflows from it.
+      # A desktop tag that fails to cut costs one manual `git tag`; a failed step
+      # here would block npm, the Marketplace and the CDN behind it. Never let
+      # this be the thing that stops a release — but annotate every skip, since
+      # a silent no-op is the exact failure being fixed.
+      - name: Cut the desktop release tag on a version bump
+        continue-on-error: true
+        env:
+          GH_TOKEN: ${{ steps.release-bot.outputs.token }}
+        run: |
+          set -uo pipefail
+          read_version() { git show "$1:apps/desktop/package.json" 2>/dev/null | node -p 'JSON.parse(require("fs").readFileSync(0, "utf8")).version' 2>/dev/null; }
+          prev="$(read_version 'HEAD^' || true)"
+          curr="$(read_version 'HEAD' || true)"
+          if [ -z "$prev" ] || [ -z "$curr" ] || [ "$prev" = "$curr" ]; then
+            echo "::notice::Desktop version unchanged or unreadable (prev='${prev}' curr='${curr}'); no tag cut."
+            exit 0
+          fi
+          tag="desktop-v${curr}"
+          if git ls-remote --exit-code --tags origin "refs/tags/${tag}" >/dev/null 2>&1; then
+            echo "::notice::${tag} already exists; leaving it alone."
+            exit 0
+          fi
+          if ! gh api "repos/${GITHUB_REPOSITORY}/git/refs" \
+            -f ref="refs/tags/${tag}" \
+            -f sha="${GITHUB_SHA}" > /dev/null; then
+            echo "::error::Could not cut ${tag}. Desktop ${curr} will not ship until someone pushes it: git tag ${tag} ${GITHUB_SHA} && git push origin ${tag}"
+            exit 1
+          fi
+          echo "Cut ${tag} at ${GITHUB_SHA} (desktop ${prev} -> ${curr})."
+
       - name: Request CodeRabbit review on version PR
         if: steps.changesets.outputs.published != 'true'
         env: