test: tighten review coverage and teardown

Author: elkaix

apps/pythinker-web/test/task-detach.test.ts

@@ -173,7 +173,7 @@ describe('detachTask API client', () => {
     const api = new DaemonPythinkerWebApi({
       serverHttpUrl: 'http://example.test:58627',
       clientId: 'web_test',
-      clientName: 'pythinker-code-web',
+      clientName: 'test',
       clientVersion: '0.1.1',
       clientUiMode: 'web',
     });

packages/agent-core-v2/test/app/workspaceAliases/workspaceAliasesService.test.ts

@@ -40,6 +40,7 @@ interface SessionIndexLine {
 describe('WorkspaceAliasesService (file-backed)', () => {
   let homeDir: string;
   let currentHost: ReturnType<typeof createScopedTestHost> | undefined;
+  let currentPersistence: FileWorkspacePersistence | undefined;
 
   beforeEach(async () => {
     _clearScopedRegistryForTests();
@@ -70,6 +71,8 @@ describe('WorkspaceAliasesService (file-backed)', () => {
   afterEach(async () => {
     currentHost?.dispose();
     currentHost = undefined;
+    currentPersistence?.dispose();
+    currentPersistence = undefined;
     await fsp.rm(homeDir, { recursive: true, force: true });
   });
 
@@ -288,9 +291,8 @@ describe('WorkspaceAliasesService (file-backed)', () => {
     const legacyId = 'wd_proj_deadbeef0002';
     await writeWorkspacesJson({ [typedId]: entry(typedRoot) });
     const storage = new FileStorageService(homeDir);
-    const persistence = new GatedPersistence(
-      new FileWorkspacePersistence(new JsonAtomicDocumentStore(storage)),
-    );
+    currentPersistence = new FileWorkspacePersistence(new JsonAtomicDocumentStore(storage));
+    const persistence = new GatedPersistence(currentPersistence);
     const aliases = build(undefined, storage, persistence);
     const ws = (id: string, root: string): Workspace => ({
       id,

packages/transcript/test/layers.test.ts

@@ -870,6 +870,42 @@ describe('groupMessagesIntoSnapshot (cold path)', () => {
     expect(turn.attachmentIds).toEqual(['att_1']);
   });
 
+  it.each(['user', 'skill_activation'] as const)(
+    'filters malformed origin file attachments on %s messages',
+    (kind) => {
+      const snapshot = groupMessagesIntoSnapshot([
+        {
+          role: 'user',
+          content: [{ type: 'text', text: 'attached files' }],
+          toolCalls: [],
+          origin: {
+            kind,
+            ...(kind === 'skill_activation' ? { trigger: 'user-slash' } : {}),
+            attachments: [
+              null,
+              { name: 'wrong-size.txt', mediaType: 'text/plain', size: '12' },
+              { name: 'note.txt', mediaType: 'text/plain', size: 12, path: '/data/note.txt' },
+              { name: 'wrong-path.txt', mediaType: 'text/plain', size: 12, path: 42 },
+            ],
+          } as { kind: string; trigger?: string; attachments: unknown },
+        },
+        { role: 'assistant', content: [{ type: 'text', text: 'done' }], toolCalls: [] },
+      ]);
+
+      expect(snapshot.attachments).toEqual([
+        {
+          attachmentId: 'att_1',
+          mediaType: 'text/plain',
+          name: 'note.txt',
+          size: 12,
+        },
+      ]);
+      const turn = snapshot.items.find((item) => item.kind === 'turn');
+      if (turn?.kind !== 'turn') throw new Error('expected turn');
+      expect(turn.attachmentIds).toEqual(['att_1']);
+    },
+  );
+
   it('maps persisted pythinker-file media refs to attachments', () => {
     const snapshot = groupMessagesIntoSnapshot([
       {