You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Superset's image: naming/tag scheme differs slightly from Dagster's (see .github/workflows/publish-images.yml's per-image "Determine version" step, which derives Superset's base version from apache/superset:<version> rather than a pip package version) — confirm the registry image reference this module emits matches what publish-images.yml actually publishes for cds-superset.
Consider (but don't require) whether the image.source/image.tag schema fragment should be factored into a shared JSON Schema definition reused by both modules, now that two modules use it — if straightforward, do it here; otherwise file a follow-up.
Part of #407, depends on #532 (renderer mechanism/first adopter in Dagster must land first so the pattern is proven).
Scope
image.source(enumbuild/registry, defaultbuild) andimage.tagconfig tomodules/bi/superset/module.yaml'sconfigSchema, reusing the mechanism built in image.source: build|registry — renderer mechanism to emit image: instead of build: #532 rather than duplicating logic.image:naming/tag scheme differs slightly from Dagster's (see.github/workflows/publish-images.yml's per-image "Determine version" step, which derives Superset's base version fromapache/superset:<version>rather than a pip package version) — confirm the registry image reference this module emits matches whatpublish-images.ymlactually publishes forcds-superset.tests/test_renderer.py/tests/test_planner.pymirroring image.source: build|registry — renderer mechanism to emit image: instead of build: #532's Dagster coverage, for Superset.image.source/image.tagschema fragment should be factored into a shared JSON Schema definition reused by both modules, now that two modules use it — if straightforward, do it here; otherwise file a follow-up.Relationship
Parent issue: #407. Depends on #532.