If we look at [`Api_Connector`](https://github.com/Semantics3/semantics3-php/blob/72ab0475e6e7949b69f9ed1281f676dd685c80e2/lib/Semantics3/ApiConnector.php#L57-L59), we can see the following: ```php public function run_query($endpoint, $params, $method="GET", array $requestOptions = []) { // ... try { // ... } catch(OAuthException2 $e) { print "\n"; $error = $e->getMessage(); print $error."\n"; } } ``` To me this seems like a two-fold problem: * this generates output, and could result in issues when trying to set response headers in consuming code, and sending data * this could possibly leak sensitive data Seems like the only way to fix this in consuming code would be to use output buffering, so how about fixing it here instead? The best and easiest way would be to just let the exception bubble up and let consuming code handle it, instead.
If we look at
Api_Connector, we can see the following:To me this seems like a two-fold problem:
Seems like the only way to fix this in consuming code would be to use output buffering, so how about fixing it here instead?
The best and easiest way would be to just let the exception bubble up and let consuming code handle it, instead.