Hebrew OTP support from PR #117 is not working in the released app
I’m using the released 2FHey app from Gumroad. English OTP detection works, but Hebrew messages still do not.
PR #117 was merged and added Hebrew support by adding:
- TwoFHey/OTPKeywords/he.json
- he.json to SimpleOTPParser.languageFiles
However, my installed /Applications/2FHey.app binary still appears to be from before that PR. It only has this compiled language list:
en.json, fr.json, zh.json, es.json, de.json, pt.json
It does not include he.json, so on launch it never fetches:
https://raw.githubusercontent.com/SoFriendly/2fhey/main/TwoFHey/OTPKeywords/he.json
This also means the README statement “All users will receive the new language support on their next app launch (no binary update required!)” is not true for newly added languages, because the app uses a hardcoded languageFiles list. It is only true for updates to language files the binary already knows about.
One more related issue: current main has this in SimpleOTPParser.swift:
private static let skipGitHubUpdate = true
That seems to disable the README’s advertised GitHub background update behavior:
“Background update: Fetches latest from GitHub on each app launch”
Could you please publish a new signed/Gumroad build that includes PR #117, and also confirm whether skipGitHubUpdate should be set back to false before release?
Hebrew OTP support from PR #117 is not working in the released app
I’m using the released 2FHey app from Gumroad. English OTP detection works, but Hebrew messages still do not.
PR #117 was merged and added Hebrew support by adding:
However, my installed /Applications/2FHey.app binary still appears to be from before that PR. It only has this compiled language list:
en.json, fr.json, zh.json, es.json, de.json, pt.json
It does not include he.json, so on launch it never fetches:
https://raw.githubusercontent.com/SoFriendly/2fhey/main/TwoFHey/OTPKeywords/he.json
This also means the README statement “All users will receive the new language support on their next app launch (no binary update required!)” is not true for newly added languages, because the app uses a hardcoded languageFiles list. It is only true for updates to language files the binary already knows about.
One more related issue: current main has this in SimpleOTPParser.swift:
private static let skipGitHubUpdate = true
That seems to disable the README’s advertised GitHub background update behavior:
“Background update: Fetches latest from GitHub on each app launch”
Could you please publish a new signed/Gumroad build that includes PR #117, and also confirm whether skipGitHubUpdate should be set back to false before release?