Skip to content

Localize Google callback session recovery #1833

@Uarmagan

Description

@Uarmagan

What to build

Clean up the Google callback recovery flow so the special case is owned by the Google callback path, not spread across the callback view, authorization helper, shared API options/types, and shared request utility.

Today the structural concern spans:

  • complete-google-authorization.ts
  • GoogleAuthCallback.tsx
  • common/apis/api.types.ts
  • common/apis/util/api.util.ts

The goal is to preserve the current user-facing behavior while making the recovery path easier to reason about: when a Google Calendar connect callback returns after the Compass session has expired, the Google callback flow should handle that recovery locally by continuing through Google sign-in.

Keep this scoped to structural cleanup only. Do not include the immediate skipSessionRecovery safety fix in this issue.

Acceptance criteria

  • Google callback recovery behavior is preserved.
  • The Google-specific recovery decision lives in the Google callback/authorization flow.
  • Shared API request configuration no longer needs a Google-callback-specific escape hatch unless there is a clearly documented reason.
  • Normal shared session handling stays general-purpose.
  • Focused Google auth/callback/API tests pass, with coverage updated if the structure changes.

Blocked by

None - can start immediately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions