GetADUsers.py — identical pattern, same inline loop GitHub
GetLAPSPassword.py — same again for lapsPassword GitHub
secretsdump.py — same pattern, this time for msDS-PrincipalName and objectSid
Creating this issue to keep a track for myself for working on two functions to prevent inline code processing and deduplicate code to have a single source of truth. GetADUsers, GetADComputers, GetLAPSPassword, and secretsdump all inline the same 3-line LDAP attribute lookup. Will make a PR that moves it to utils.py for easy reuse
GetADUsers.py — identical pattern, same inline loop GitHub
GetLAPSPassword.py — same again for lapsPassword GitHub
secretsdump.py — same pattern, this time for msDS-PrincipalName and objectSid
Creating this issue to keep a track for myself for working on two functions to prevent inline code processing and deduplicate code to have a single source of truth. GetADUsers, GetADComputers, GetLAPSPassword, and secretsdump all inline the same 3-line LDAP attribute lookup. Will make a PR that moves it to utils.py for easy reuse