You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But, it doesn't impl a document picker/export flow for downloaded files. The final file is written to the app sandbox, via YouModDownloadsDirectoryURL() and YouModUniqueFileURL().
Thus,
when "downloaded things is not Photo-compatible" or "option DownloadSaveToPhotos is disable",
the file is saved only inside the app sandbox and no user-visible export/share flow is presented.
Note
Current behavior:
if (isVideo&&IS_ENABLED(DownloadSaveToPhotos) &&canSaveToPhotos) {
// save to Photos
} else {
// toast, *no export*
}
isVideo == NO
canSaveToPhotos == NO
DownloadSaveToPhotos == NO
→ only toast, no share sheet, no Files export picker
If DownloadSaveToPhotos == enabled:
*keep the current behavior* and save Photos-compatible videos to Photos.
If DownloadSaveToPhotos == disabled:
present a user-visible export flow, such as `UIDocumentPickerViewController`,
so the user can choose where to save the downloaded file.
Then update completeWithFileURL:isVideo:presenter: so that Photos-compatible videos with DownloadSaveToPhotos disabled are exported through this picker instead of only showing a completion toast.
Steps to reproduce
Enable "Download Manager" under setting "YouMod" item.
Download sth(video, subtitle, ...) of video.
After download process completing, there is nothing happen(file is saved to under app sandbox).
Crashlog or video error popup log
No response
Post requisites
I have CHECKED that a similar issue has not been reported before.
Verified the relevance of the project and the version you are using.
Provided a detailed description of the problem and have filled in all required fields.
By submitting this issue, I confirm that I have filled in all the necessary fields and complied with the guidelines. Failure to comply may result in the issue being closed without discussion, and repeated violations may lead to restrict account from further participation.
Describe the bug
In Download.x,it import:
But, it doesn't impl a document picker/export flow for downloaded files.
The final file is written to the app sandbox, via
YouModDownloadsDirectoryURL()andYouModUniqueFileURL().Thus,
when "downloaded things is not Photo-compatible" or "option
DownloadSaveToPhotosis disable",the file is saved only inside the app sandbox and no user-visible export/share flow is presented.
Note
Current behavior:
For fixing, the intended bahabior:
If DownloadSaveToPhotos == enabled: *keep the current behavior* and save Photos-compatible videos to Photos. If DownloadSaveToPhotos == disabled: present a user-visible export flow, such as `UIDocumentPickerViewController`, so the user can choose where to save the downloaded file.For impl, add an export helper in Download.x, similiar to the export logic already used in YouModPerferences.x:
Then update
completeWithFileURL:isVideo:presenter:so that Photos-compatible videos with DownloadSaveToPhotos disabled are exported through this picker instead of only showing a completion toast.Steps to reproduce
Crashlog or video error popup log
No response
Post requisites