From fdce14ace749e431f396540fa711d66a93bcf85e Mon Sep 17 00:00:00 2001 From: Todor Stoyanov Date: Mon, 10 Aug 2026 09:03:42 +0300 Subject: [PATCH 1/6] fix(ui5-split-button): announce accessible name before instructions --- packages/main/src/SplitButtonTemplate.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/SplitButtonTemplate.tsx b/packages/main/src/SplitButtonTemplate.tsx index 3b015ef90b90c..5125348da9c11 100644 --- a/packages/main/src/SplitButtonTemplate.tsx +++ b/packages/main/src/SplitButtonTemplate.tsx @@ -56,7 +56,7 @@ export default function SplitButtonTemplate(this: SplitButton) { onActiveStateChange={this._onArrowButtonActiveStateChange} > - {this.accInfo.keyboardHint} {this.accessibleName} + {this.accessibleName} {this.accInfo.keyboardHint} {this.buttonTextContent} )} From b5a45813d8d149e5a9f32bc86077c6710ddf4296 Mon Sep 17 00:00:00 2001 From: Todor Stoyanov Date: Thu, 13 Aug 2026 09:21:53 +0300 Subject: [PATCH 2/6] fix(ui5-split-button): announce accessible name before instructions --- packages/main/src/SplitButton.ts | 2 +- packages/main/src/SplitButtonTemplate.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/main/src/SplitButton.ts b/packages/main/src/SplitButton.ts index 55183c6ed94af..8955d12089325 100644 --- a/packages/main/src/SplitButton.ts +++ b/packages/main/src/SplitButton.ts @@ -469,7 +469,7 @@ class SplitButton extends UI5Element { return { root: { hasPopup: this.accessibilityAttributes?.root?.hasPopup, - roleDescription: this.accessibilityAttributes?.root?.roleDescription || (this._hideArrowButton ? undefined : SplitButton.i18nBundle.getText(SPLIT_BUTTON_DESCRIPTION)), + roleDescription: this.accessibilityAttributes?.root?.roleDescription, title: this.accessibilityAttributes?.root?.title, ariaKeyShortcuts: this.accessibilityAttributes?.root?.ariaKeyShortcuts, }, diff --git a/packages/main/src/SplitButtonTemplate.tsx b/packages/main/src/SplitButtonTemplate.tsx index 5125348da9c11..4dfaa46c43f8d 100644 --- a/packages/main/src/SplitButtonTemplate.tsx +++ b/packages/main/src/SplitButtonTemplate.tsx @@ -56,7 +56,7 @@ export default function SplitButtonTemplate(this: SplitButton) { onActiveStateChange={this._onArrowButtonActiveStateChange} > - {this.accessibleName} {this.accInfo.keyboardHint} + {this.accessibleName} {this.accInfo.description} {this.accInfo.keyboardHint} {this.buttonTextContent} )} From ae867efb4a4a9d58d50abeb1b8fd900926af5b9d Mon Sep 17 00:00:00 2001 From: Todor Stoyanov Date: Fri, 14 Aug 2026 11:55:26 +0300 Subject: [PATCH 3/6] fix(ui5-split-button): announce accessible name before instructions --- packages/main/src/SplitButton.ts | 5 +---- packages/main/src/SplitButtonTemplate.tsx | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/main/src/SplitButton.ts b/packages/main/src/SplitButton.ts index 8955d12089325..4d91d67cb5f7c 100644 --- a/packages/main/src/SplitButton.ts +++ b/packages/main/src/SplitButton.ts @@ -38,7 +38,7 @@ import SplitButtonTemplate from "./SplitButtonTemplate.js"; // Styles import SplitButtonCss from "./generated/themes/SplitButton.css.js"; -type SplitButtonRootAccAttributes = Pick; +type SplitButtonRootAccAttributes = Pick; type SplitButtonArrowButtonAccAtributes = Pick; type SplitButtonAccessibilityAttributes = {root?: SplitButtonRootAccAttributes, arrowButton?: SplitButtonArrowButtonAccAtributes} @@ -224,8 +224,6 @@ class SplitButton extends UI5Element { * - **root**: Attributes that will be applied to the main (text) button. * - **hasPopup**: Indicates the presence and type of popup triggered by the button. * Accepts string values: `"dialog"`, `"grid"`, `"listbox"`, `"menu"`, or `"tree"`. - * - **roleDescription**: Provides a human-readable description for the role of the button. - * Accepts any string value. * - **title**: Specifies a tooltip or description for screen readers. * Accepts any string value. * - **ariaKeyShortcuts**: Defines keyboard shortcuts that activate or give focus to the button. @@ -469,7 +467,6 @@ class SplitButton extends UI5Element { return { root: { hasPopup: this.accessibilityAttributes?.root?.hasPopup, - roleDescription: this.accessibilityAttributes?.root?.roleDescription, title: this.accessibilityAttributes?.root?.title, ariaKeyShortcuts: this.accessibilityAttributes?.root?.ariaKeyShortcuts, }, diff --git a/packages/main/src/SplitButtonTemplate.tsx b/packages/main/src/SplitButtonTemplate.tsx index 4dfaa46c43f8d..de7d9f726dd2c 100644 --- a/packages/main/src/SplitButtonTemplate.tsx +++ b/packages/main/src/SplitButtonTemplate.tsx @@ -10,8 +10,7 @@ export default function SplitButtonTemplate(this: SplitButton) { tabindex={this._tabIndex} aria-labelledby={!this._hideArrowButton ? `${this._id}-invisibleTextDefault ${this._id}-invisibleText` : undefined} aria-haspopup={this._computedAccessibilityAttributes?.root?.hasPopup} - aria-roledescription={this._computedAccessibilityAttributes?.root?.roleDescription} - aria-label={this._computedAccessibilityAttributes?.root?.title} +aria-label={this._computedAccessibilityAttributes?.root?.title} aria-keyshortcuts={this._computedAccessibilityAttributes?.root?.ariaKeyShortcuts} onFocusOut={this._onFocusOut} onKeyDown={this._onKeyDown} From c8183b101b4266869853a3d5f87894f3e134f691 Mon Sep 17 00:00:00 2001 From: Todor Stoyanov Date: Mon, 17 Aug 2026 13:21:06 +0300 Subject: [PATCH 4/6] fix(ui5-split-button): fix indentation in SplitButtonTemplate --- packages/main/src/SplitButtonTemplate.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/SplitButtonTemplate.tsx b/packages/main/src/SplitButtonTemplate.tsx index de7d9f726dd2c..608cd6988cf0b 100644 --- a/packages/main/src/SplitButtonTemplate.tsx +++ b/packages/main/src/SplitButtonTemplate.tsx @@ -10,7 +10,7 @@ export default function SplitButtonTemplate(this: SplitButton) { tabindex={this._tabIndex} aria-labelledby={!this._hideArrowButton ? `${this._id}-invisibleTextDefault ${this._id}-invisibleText` : undefined} aria-haspopup={this._computedAccessibilityAttributes?.root?.hasPopup} -aria-label={this._computedAccessibilityAttributes?.root?.title} + aria-label={this._computedAccessibilityAttributes?.root?.title} aria-keyshortcuts={this._computedAccessibilityAttributes?.root?.ariaKeyShortcuts} onFocusOut={this._onFocusOut} onKeyDown={this._onKeyDown} From b2bdc38a4e7fb4a62ad2f6caf5878cad08018b38 Mon Sep 17 00:00:00 2001 From: Todor Stoyanov Date: Mon, 17 Aug 2026 14:41:32 +0300 Subject: [PATCH 5/6] fix(ui5-split-button): announce accessible name before instructions --- packages/ai/cypress/specs/Button.cy.tsx | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/ai/cypress/specs/Button.cy.tsx b/packages/ai/cypress/specs/Button.cy.tsx index 9ea372f76c809..4a9f2a897cf39 100644 --- a/packages/ai/cypress/specs/Button.cy.tsx +++ b/packages/ai/cypress/specs/Button.cy.tsx @@ -37,7 +37,7 @@ describe("Accessibility", () => { .ui5AIButtonCheckAttributeSplitButtonRoot("aria-haspopup", "menu"); }); - it("should set correct aria-roledescription to SplitButton root element", () => { + it("should not set aria-roledescription to SplitButton root element", () => { cy.mount(