refactor(android): drop the two call callbacks Android never delivers (#368)

The calling plugin offered two events that only an iPhone can produce:
continuing a call started from the system's own recents or voice
assistant, and the reset the system sends when it drops every call it
was tracking. On Android nothing has ever raised either of them, yet
both looked like part of the shared contract, inviting Android logic
that could never run.

Both are now removed from the Android side and marked as iOS-only in
the shared interface and the documentation, so the contract says what
actually happens. The version of the tool that produces the generated
message files is pinned alongside, so those files stay stable.

Author: SERDUN

AGENTS.md

@@ -98,7 +98,10 @@ WebtritCallkeepPlatform (platform_interface)
 
 **Platform to Flutter** (via `CallkeepDelegate`): `performStartCall`, `performAnswerCall`, `performEndCall`,
 `performSetHeld`, `performSetMuted`, `performSendDTMF`, `performAudioDeviceSet`, `performAudioDevicesUpdate`,
-`didActivateAudioSession`, `didDeactivateAudioSession`, `didReset`, `continueStartCallIntent`, `didPushIncomingCall`.
+`didActivateAudioSession`, `didDeactivateAudioSession`, `didPushIncomingCall`.
+
+`didReset` and `continueStartCallIntent` are declared on `CallkeepDelegate` but are delivered by iOS only:
+the Android side has no source for either event, so they are absent from the Android pigeon surface.
 
 `perform*` methods return `Future<bool>` — return `true` on success, `false` on failure.
 Returning `false` causes the native side to abort the operation.

README.md

@@ -150,14 +150,14 @@ Implement `CallkeepDelegate` and pass it to `setDelegate` to receive platform ev
 | `performAnswerCall(callId)` | User answered from system UI |
 | `performEndCall(callId)` | User ended from system UI or system terminated the call |
 | `performStartCall(callId, handle, ...)` | User initiated outgoing call from system UI (e.g. Siri) |
-| `continueStartCallIntent(callId, handle, ...)` | System confirmed outgoing call intent |
+| `continueStartCallIntent(callId, handle, ...)` | System confirmed outgoing call intent (iOS only) |
 | `performSetHeld(callId, onHold)` | User toggled hold from system UI |
 | `performSetMuted(callId, muted)` | User toggled mute from system UI |
 | `performSendDTMF(callId, digit)` | User sent DTMF from system dial pad |
 | `performSetSpeaker(callId, on)` | User toggled speaker from system UI |
 | `didActivateAudioSession()` | System activated the audio session |
 | `didDeactivateAudioSession()` | System deactivated the audio session |
-| `didReset()` | System reset all call state |
+| `didReset()` | System reset all call state (iOS only) |
 
 `perform*` methods return `Future<bool>`. Return `false` to signal failure — the platform will
 terminate the call.

webtrit_callkeep_android/android/src/main/kotlin/com/webtrit/callkeep/Generated.kt

@@ -2296,23 +2296,6 @@ class PDelegateFlutterApi(private val binaryMessenger: BinaryMessenger, private
       GeneratedPigeonCodec()
     }
   }
-  fun continueStartCallIntent(handleArg: PHandle, displayNameArg: String?, videoArg: Boolean, callback: (Result<Unit>) -> Unit)
-{
-    val separatedMessageChannelSuffix = if (messageChannelSuffix.isNotEmpty()) ".$messageChannelSuffix" else ""
-    val channelName = "dev.flutter.pigeon.webtrit_callkeep_android.PDelegateFlutterApi.continueStartCallIntent$separatedMessageChannelSuffix"
-    val channel = BasicMessageChannel<Any?>(binaryMessenger, channelName, codec)
-    channel.send(listOf(handleArg, displayNameArg, videoArg)) {
-      if (it is List<*>) {
-        if (it.size > 1) {
-          callback(Result.failure(FlutterError(it[0] as String, it[1] as String, it[2] as String?)))
-        } else {
-          callback(Result.success(Unit))
-        }
-      } else {
-        callback(Result.failure(GeneratedPigeonUtils.createConnectionError(channelName)))
-      } 
-    }
-  }
   fun didPushIncomingCall(handleArg: PHandle, displayNameArg: String?, videoArg: Boolean, callIdArg: String, errorArg: PIncomingCallError?, callback: (Result<Unit>) -> Unit)
 {
     val separatedMessageChannelSuffix = if (messageChannelSuffix.isNotEmpty()) ".$messageChannelSuffix" else ""
@@ -2524,23 +2507,6 @@ class PDelegateFlutterApi(private val binaryMessenger: BinaryMessenger, private
       } 
     }
   }
-  fun didReset(callback: (Result<Unit>) -> Unit)
-{
-    val separatedMessageChannelSuffix = if (messageChannelSuffix.isNotEmpty()) ".$messageChannelSuffix" else ""
-    val channelName = "dev.flutter.pigeon.webtrit_callkeep_android.PDelegateFlutterApi.didReset$separatedMessageChannelSuffix"
-    val channel = BasicMessageChannel<Any?>(binaryMessenger, channelName, codec)
-    channel.send(null) {
-      if (it is List<*>) {
-        if (it.size > 1) {
-          callback(Result.failure(FlutterError(it[0] as String, it[1] as String, it[2] as String?)))
-        } else {
-          callback(Result.success(Unit))
-        }
-      } else {
-        callback(Result.failure(GeneratedPigeonUtils.createConnectionError(channelName)))
-      } 
-    }
-  }
 }
 /** Generated class from Pigeon that represents Flutter messages that can be called from Kotlin. */
 class PDelegateBackgroundServiceFlutterApi(private val binaryMessenger: BinaryMessenger, private val messageChannelSuffix: String = "") {

webtrit_callkeep_android/lib/src/common/callkeep.pigeon.dart

@@ -2100,8 +2100,6 @@ class PHostConnectionsApi {
 abstract class PDelegateFlutterApi {
   static const MessageCodec<Object?> pigeonChannelCodec = _PigeonCodec();
 
-  void continueStartCallIntent(PHandle handle, String? displayName, bool video);
-
   void didPushIncomingCall(PHandle handle, String? displayName, bool video, String callId, PIncomingCallError? error);
 
   Future<bool> performStartCall(String callId, PHandle handle, String? displayNameOrContactIdentifier, bool video);
@@ -2124,33 +2122,8 @@ abstract class PDelegateFlutterApi {
 
   void didDeactivateAudioSession();
 
-  void didReset();
-
   static void setUp(PDelegateFlutterApi? api, {BinaryMessenger? binaryMessenger, String messageChannelSuffix = '',}) {
     messageChannelSuffix = messageChannelSuffix.isNotEmpty ? '.$messageChannelSuffix' : '';
-    {
-      final pigeonVar_channel = BasicMessageChannel<Object?>(
-          'dev.flutter.pigeon.webtrit_callkeep_android.PDelegateFlutterApi.continueStartCallIntent$messageChannelSuffix', pigeonChannelCodec,
-          binaryMessenger: binaryMessenger);
-      if (api == null) {
-        pigeonVar_channel.setMessageHandler(null);
-      } else {
-        pigeonVar_channel.setMessageHandler((Object? message) async {
-          final List<Object?> args = message! as List<Object?>;
-          final PHandle arg_handle = args[0]! as PHandle;
-          final String? arg_displayName = args[1] as String?;
-          final bool arg_video = args[2]! as bool;
-          try {
-            api.continueStartCallIntent(arg_handle, arg_displayName, arg_video);
-            return wrapResponse(empty: true);
-          } on PlatformException catch (e) {
-            return wrapResponse(error: e);
-          }          catch (e) {
-            return wrapResponse(error: PlatformException(code: 'error', message: e.toString()));
-          }
-        });
-      }
-    }
     {
       final pigeonVar_channel = BasicMessageChannel<Object?>(
           'dev.flutter.pigeon.webtrit_callkeep_android.PDelegateFlutterApi.didPushIncomingCall$messageChannelSuffix', pigeonChannelCodec,
@@ -2390,25 +2363,6 @@ abstract class PDelegateFlutterApi {
         });
       }
     }
-    {
-      final pigeonVar_channel = BasicMessageChannel<Object?>(
-          'dev.flutter.pigeon.webtrit_callkeep_android.PDelegateFlutterApi.didReset$messageChannelSuffix', pigeonChannelCodec,
-          binaryMessenger: binaryMessenger);
-      if (api == null) {
-        pigeonVar_channel.setMessageHandler(null);
-      } else {
-        pigeonVar_channel.setMessageHandler((Object? message) async {
-          try {
-            api.didReset();
-            return wrapResponse(empty: true);
-          } on PlatformException catch (e) {
-            return wrapResponse(error: e);
-          }          catch (e) {
-            return wrapResponse(error: PlatformException(code: 'error', message: e.toString()));
-          }
-        });
-      }
-    }
   }
 }
 

webtrit_callkeep_android/lib/src/webtrit_callkeep_android.dart

@@ -390,11 +390,6 @@ class _CallkeepDelegateRelay implements PDelegateFlutterApi {
 
   final CallkeepDelegate _delegate;
 
-  @override
-  void continueStartCallIntent(PHandle handle, String? displayName, bool video) {
-    _delegate.continueStartCallIntent(handle.toCallkeep(), displayName, video);
-  }
-
   @override
   void didPushIncomingCall(PHandle handle, String? displayName, bool video, String callId, PIncomingCallError? error) {
     _delegate.didPushIncomingCall(handle.toCallkeep(), displayName, video, callId, error?.value.toCallkeep());
@@ -465,11 +460,6 @@ class _CallkeepDelegateRelay implements PDelegateFlutterApi {
   void didDeactivateAudioSession() {
     _delegate.didDeactivateAudioSession();
   }
-
-  @override
-  void didReset() {
-    _delegate.didReset();
-  }
 }
 
 class _PushRegistryDelegateRelay implements PPushRegistryDelegateFlutterApi {

webtrit_callkeep_android/pigeons/callkeep.messages.dart

@@ -427,9 +427,6 @@ abstract class PHostConnectionsApi {
 
 @FlutterApi()
 abstract class PDelegateFlutterApi {
-  @ObjCSelector('continueStartCallIntentHandle:displayName:video:')
-  void continueStartCallIntent(PHandle handle, String? displayName, bool video);
-
   @ObjCSelector('didPushIncomingCallHandle:displayName:video:id:error:')
   void didPushIncomingCall(PHandle handle, String? displayName, bool video, String callId, PIncomingCallError? error);
 
@@ -470,9 +467,6 @@ abstract class PDelegateFlutterApi {
 
   @ObjCSelector('didDeactivateAudioSession')
   void didDeactivateAudioSession();
-
-  @ObjCSelector('didReset')
-  void didReset();
 }
 
 @FlutterApi()

webtrit_callkeep_android/pubspec.yaml

@@ -24,6 +24,6 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  pigeon: ^27.0.0
+  pigeon: 27.1.0
   plugin_platform_interface: ^2.1.8
   flutter_lints: ^6.0.0

webtrit_callkeep_android/test/delegate_relay_test.dart

@@ -182,30 +182,6 @@ void main() {
       expect(() => WebtritCallkeepPlatform.instance.setDelegate(null), returnsNormally);
     });
 
-    test('continueStartCallIntent forwards converted handle and args', () async {
-      await _send('$_prefix.PDelegateFlutterApi.continueStartCallIntent', [
-        PHandle(type: PHandleTypeEnum.number, value: '+1234'),
-        'Alice',
-        true,
-      ]);
-      expect(fake.calls['continueStartCallIntent'], hasLength(1));
-      final args = fake.calls['continueStartCallIntent']![0];
-      expect((args[0] as CallkeepHandle).type, CallkeepHandleType.number);
-      expect((args[0] as CallkeepHandle).value, '+1234');
-      expect(args[1], 'Alice');
-      expect(args[2], true);
-    });
-
-    test('continueStartCallIntent forwards null displayName', () async {
-      await _send('$_prefix.PDelegateFlutterApi.continueStartCallIntent', [
-        PHandle(type: PHandleTypeEnum.email, value: 'a@b.com'),
-        null,
-        false,
-      ]);
-      final args = fake.calls['continueStartCallIntent']![0];
-      expect(args[1], isNull);
-    });
-
     test('didPushIncomingCall with null error forwards null error', () async {
       await _send('$_prefix.PDelegateFlutterApi.didPushIncomingCall', [
         PHandle(type: PHandleTypeEnum.number, value: '555'),
@@ -325,11 +301,6 @@ void main() {
       await _send('$_prefix.PDelegateFlutterApi.didDeactivateAudioSession', []);
       expect(fake.calls['didDeactivateAudioSession'], hasLength(1));
     });
-
-    test('didReset calls delegate', () async {
-      await _send('$_prefix.PDelegateFlutterApi.didReset', []);
-      expect(fake.calls['didReset'], hasLength(1));
-    });
   });
 
   // ---------------------------------------------------------------------------

webtrit_callkeep_ios/pubspec.yaml

@@ -24,6 +24,6 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
-  pigeon: ^27.0.0
+  pigeon: 27.1.0
   plugin_platform_interface: ^2.1.8
   flutter_lints: ^6.0.0

webtrit_callkeep_platform_interface/README.md

@@ -70,14 +70,14 @@ CallkeepHandle.sip('user@example.com')
 | `performAnswerCall` | User answered from system UI |
 | `performEndCall` | User ended from system UI or system terminated the call |
 | `performStartCall` | User initiated outgoing call from system UI |
-| `continueStartCallIntent` | System confirmed outgoing call intent |
+| `continueStartCallIntent` | System confirmed outgoing call intent (iOS only) |
 | `performSetHeld` | Hold toggled from system UI |
 | `performSetMuted` | Mute toggled from system UI |
 | `performSendDTMF` | DTMF sent from system dial pad |
 | `performSetSpeaker` | Speaker toggled from system UI |
 | `didActivateAudioSession` | System activated the audio session |
 | `didDeactivateAudioSession` | System deactivated the audio session |
-| `didReset` | System reset all call state |
+| `didReset` | System reset all call state (iOS only) |
 
 `perform*` methods return `Future<bool>`. Return `false` to signal failure — the platform
 terminates the call.