Missing attachments for preview

[Crykon]

Hi, while working on preview optimization (and it looks promising even comparing to compression+resize time to disk space occupancy (and the Gif to Webm convertation is still in TODO ) ), I discovered an issue when the app previews count and the site previews don't match. For example: on this url Safe For Work
There are 30 previews, whereas in the data base the list contains only 17 of them:

PinUp_DataBase.txt

Missing.txt

Not sure what's causing it, but I'll look it up and maybe will find the solution, for now not a big problem, but need further investigation till release datetime

[WillyJL]

this is normal. the indexer api just takes what latest updates lists, at face value. it doesnt take previews from the thread. also because, taking previews from the thread could have mistakes and pick up tutorial screenshots or something else from main thread that isnt a preview. trusting latest updates allows to have a more curated set of previews

[WillyJL]

can always add later on that the indexer api will look in the thread, but for now i dont see the need, are you really gonna need 30 whole previews xD

[WillyJL]

@Crykon just fyi, i plan to get #294 (compression here is about astc/bc7 for faster loading of cover images with no quality loss but at expense of higher space usage, unrelated to the kind of compression youre working on for previews which i assume is more like thumbnailing/downscaling) implemented today/tomorrow, so imagehelper and image loading might get restructured somewhat significantly. just as a warning in case youre moving ahead to implement the ideas you proposed yesterday in #293, i suggest waiting a few days before going for a final implementation, do all preliminary tests you need of course but hold off on putting effort into good quality final code :)

[Crykon]

Oh, good. It's hard to stop, but I'll compare the changes and see what's changed. Thanks for mentioning your plans, I really need to get away from the computer to clear my head xQ

[WillyJL]

@Crykon im done with changes to imagehelper for now, and probably for quite a while lol. youre clear to go crazy with whatever great ideas you have for previews space saving 🫡 i look forward to it

i did make the new astc/bc7 cover compression routine avoid compressing previews:

F95Checker/external/imagehelper.py

Lines 533 to 534 in bc6652b

	if globals.images_path / "previews" in self.resolved_path.parents:
	return False

so it compresses all covers, while previews continue loading as source images. if your plan is still (from what i understood) to store on disk some downscaled thumbnails of the original images and download full ones when opened in fullscreen viewer, then i doubt theres any advantage to re-enabling astc/bc7 compression for those downscaled previews: astc/bc7 compression is mainly to help with image loading times which is only an issue with large high resolution images, so i'd imagine the downscaled preview thumbnails would load lightspeed fast regardless, and this line can be kept as is. but just thought i'd mention it

[Crykon]

Nice @WillyJL , good job! Thanks for preserving my preview implementation as is for future modifications. I can't totally make sure that this "preview idea" will return prognosed and consistent desired result, but anyway I'm sure some of the instruments (like Gif to Webm) is still will be handy addition, even after my proto fails on global testing by me and will be costly in cpu/gpu to disk direction. In a couple of days I might be done with it and make a new pr for that, or you can check it out in my profile to see the process, if you're really interested